Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package python-sushy for openSUSE:Factory checked in at 2023-12-01 21:27:20 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/python-sushy (Old) and /work/SRC/openSUSE:Factory/.python-sushy.new.25432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-sushy" Fri Dec 1 21:27:20 2023 rev:14 rq:1130304 version:4.5.1 Changes: -------- --- /work/SRC/openSUSE:Factory/python-sushy/python-sushy.changes 2023-07-18 22:09:40.699510239 +0200 +++ /work/SRC/openSUSE:Factory/.python-sushy.new.25432/python-sushy.changes 2023-12-01 21:27:38.110875507 +0100 @@ -1,0 +2,6 @@ +Fri Dec 1 16:40:18 UTC 2023 - cloud-de...@suse.de + +- update to version 4.5.1 + - Requests must always have a read/connect timeout + +------------------------------------------------------------------- Old: ---- sushy-4.5.0.tar.gz New: ---- sushy-4.5.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ python-sushy.spec ++++++ --- /var/tmp/diff_new_pack.18XGSM/_old 2023-12-01 21:27:38.618894203 +0100 +++ /var/tmp/diff_new_pack.18XGSM/_new 2023-12-01 21:27:38.618894203 +0100 @@ -17,13 +17,13 @@ Name: python-sushy -Version: 4.5.0 +Version: 4.5.1 Release: 0 Summary: Python library to communicate with Redfish based systems License: Apache-2.0 Group: Development/Languages/Python URL: https://docs.openstack.org/sushy -Source0: https://files.pythonhosted.org/packages/source/s/sushy/sushy-4.5.0.tar.gz +Source0: https://files.pythonhosted.org/packages/source/s/sushy/sushy-4.5.1.tar.gz BuildRequires: openstack-macros BuildRequires: python3-oslotest BuildRequires: python3-pbr >= 2.0.0 @@ -62,7 +62,7 @@ This package contains the documentation. %prep -%autosetup -p1 -n sushy-4.5.0 +%autosetup -p1 -n sushy-4.5.1 %py_req_cleanup %build ++++++ _service ++++++ --- /var/tmp/diff_new_pack.18XGSM/_old 2023-12-01 21:27:38.646895233 +0100 +++ /var/tmp/diff_new_pack.18XGSM/_new 2023-12-01 21:27:38.650895380 +0100 @@ -1,13 +1,13 @@ <services> - <service mode="disabled" name="renderspec"> + <service mode="manual" name="renderspec"> <param name="input-template">https://opendev.org/openstack/rpm-packaging/raw/branch/master/openstack/sushy/sushy.spec.j2</param> <param name="output-name">python-sushy.spec</param> <param name="requirements">https://opendev.org/openstack/sushy/raw/branch/master/requirements.txt</param> <param name="changelog-email">cloud-de...@suse.de</param> <param name="changelog-provider">gh,openstack,sushy</param> </service> - <service mode="disabled" name="download_files"> + <service mode="manual" name="download_files"> </service> - <service name="format_spec_file" mode="disabled"/> + <service name="format_spec_file" mode="manual"/> </services> ++++++ sushy-4.5.0.tar.gz -> sushy-4.5.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/ChangeLog new/sushy-4.5.1/ChangeLog --- old/sushy-4.5.0/ChangeLog 2023-05-11 11:12:15.000000000 +0200 +++ new/sushy-4.5.1/ChangeLog 2023-08-24 10:59:33.000000000 +0200 @@ -1,6 +1,11 @@ CHANGES ======= +4.5.1 +----- + +* Requests must always have a read/connect timeout + 4.5.0 ----- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/PKG-INFO new/sushy-4.5.1/PKG-INFO --- old/sushy-4.5.0/PKG-INFO 2023-05-11 11:12:15.658070300 +0200 +++ new/sushy-4.5.1/PKG-INFO 2023-08-24 10:59:33.945420500 +0200 @@ -1,6 +1,6 @@ Metadata-Version: 1.2 Name: sushy -Version: 4.5.0 +Version: 4.5.1 Summary: Sushy is a small Python library to communicate with Redfish based systems Home-page: https://docs.openstack.org/sushy/latest/ Author: OpenStack diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/releasenotes/notes/add-read-and-connect-timeout-9f7dc3ed63c192c8.yaml new/sushy-4.5.1/releasenotes/notes/add-read-and-connect-timeout-9f7dc3ed63c192c8.yaml --- old/sushy-4.5.0/releasenotes/notes/add-read-and-connect-timeout-9f7dc3ed63c192c8.yaml 1970-01-01 01:00:00.000000000 +0100 +++ new/sushy-4.5.1/releasenotes/notes/add-read-and-connect-timeout-9f7dc3ed63c192c8.yaml 2023-08-24 10:59:02.000000000 +0200 @@ -0,0 +1,5 @@ +fixes: + - Fixes bug where sushy would not pass a read/connect timeout through to + requests when making requests to a redfish service. This means that an + ill-timed failure could cause python processes calling sushy to freeze + indefinately. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/sushy/connector.py new/sushy-4.5.1/sushy/connector.py --- old/sushy-4.5.0/sushy/connector.py 2023-05-11 11:11:46.000000000 +0200 +++ new/sushy-4.5.1/sushy/connector.py 2023-08-24 10:59:02.000000000 +0200 @@ -117,7 +117,11 @@ :param data: Optional JSON data. :param headers: Optional dictionary of headers. :param blocking: Whether to block for asynchronous operations. - :param timeout: Max time in seconds to wait for blocking async call. + :param timeout: Max time in seconds to wait for blocking async call or + for requests library to connect and read. If a custom + timeout for requests is provided in + extra_session_req_kwargs, it will be used instead for + those calls. :param server_side_retries_left: Remaining retries. If not provided will use limit provided by instance's server_side_retries :param extra_session_req_kwargs: Optional keyword argument to pass @@ -127,7 +131,6 @@ :raises: ConnectionError :raises: HTTPError """ - if server_side_retries_left is None: server_side_retries_left = self._server_side_retries @@ -153,6 +156,7 @@ response = self._session.request(method, url, json=data, headers=headers, verify=self._verify, + timeout=timeout, **extra_session_req_kwargs) except requests.exceptions.RequestException as e: # Capture any general exception by looking for the parent @@ -211,6 +215,7 @@ method, url, json=data, headers=headers, verify=self._verify, + timeout=timeout, **extra_session_req_kwargs) except exceptions.HTTPError as retry_exc: LOG.error("Failure occured while attempting to retry " diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/sushy/tests/unit/test_connector.py new/sushy-4.5.1/sushy/tests/unit/test_connector.py --- old/sushy-4.5.0/sushy/tests/unit/test_connector.py 2023-05-11 11:11:46.000000000 +0200 +++ new/sushy-4.5.1/sushy/tests/unit/test_connector.py 2023-08-24 10:59:02.000000000 +0200 @@ -178,7 +178,7 @@ self.conn._op('GET', path='fake/path', headers=self.headers) self.request.assert_called_once_with( 'GET', 'http://foo.bar:1234/fake/path', - headers=self.headers, json=None, verify=True) + headers=self.headers, json=None, verify=True, timeout=60) def test_response_callback(self): mock_response_callback = mock.MagicMock() @@ -193,21 +193,21 @@ self.request.assert_called_once_with( 'GET', 'http://foo.bar:1234/fake/path', headers=self.headers, json=None, allow_redirects=False, - verify=True) + verify=True, timeout=60) def test_ok_post(self): self.conn._op('POST', path='fake/path', data=self.data.copy(), headers=self.headers) self.request.assert_called_once_with( 'POST', 'http://foo.bar:1234/fake/path', - json=self.data, headers=self.headers, verify=True) + json=self.data, headers=self.headers, verify=True, timeout=60) def test_ok_put(self): self.conn._op('PUT', path='fake/path', data=self.data.copy(), headers=self.headers) self.request.assert_called_once_with( 'PUT', 'http://foo.bar:1234/fake/path', - json=self.data, headers=self.headers, verify=True) + json=self.data, headers=self.headers, verify=True, timeout=60) def test_ok_delete(self): expected_headers = self.headers.copy() @@ -215,7 +215,7 @@ self.conn._op('DELETE', path='fake/path', headers=self.headers.copy()) self.request.assert_called_once_with( 'DELETE', 'http://foo.bar:1234/fake/path', - headers=expected_headers, json=None, verify=True) + headers=expected_headers, json=None, verify=True, timeout=60) def test_ok_post_with_session(self): self.conn._session.headers = {} @@ -227,7 +227,7 @@ data=self.data) self.request.assert_called_once_with( 'POST', 'http://foo.bar:1234/fake/path', - json=self.data, headers=expected_headers, verify=True) + json=self.data, headers=expected_headers, verify=True, timeout=60) self.assertEqual(self.conn._session.headers, {'X-Auth-Token': 'asdf1234'}) @@ -240,7 +240,7 @@ self.conn._op('GET', path=path, headers=headers) self.request.assert_called_once_with( 'GET', 'http://foo.bar:1234' + path, - headers=expected_headers, json=None, verify=True) + headers=expected_headers, json=None, verify=True, timeout=60) def test_odata_version_header_redfish_no_headers(self): path = '/redfish/v1/bar' @@ -248,7 +248,7 @@ self.conn._op('GET', path=path) self.request.assert_called_once_with( 'GET', 'http://foo.bar:1234' + path, - headers=expected_headers, json=None, verify=True) + headers=expected_headers, json=None, verify=True, timeout=60) def test_odata_version_header_redfish_existing_header(self): path = '/redfish/v1/foo' @@ -257,7 +257,7 @@ self.conn._op('GET', path=path, headers=headers) self.request.assert_called_once_with( 'GET', 'http://foo.bar:1234' + path, - headers=expected_headers, json=None, verify=True) + headers=expected_headers, json=None, verify=True, timeout=60) def test_timed_out_session_unable_to_create_session(self): self.conn._auth.can_refresh_session.return_value = False diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/sushy.egg-info/PKG-INFO new/sushy-4.5.1/sushy.egg-info/PKG-INFO --- old/sushy-4.5.0/sushy.egg-info/PKG-INFO 2023-05-11 11:12:15.000000000 +0200 +++ new/sushy-4.5.1/sushy.egg-info/PKG-INFO 2023-08-24 10:59:33.000000000 +0200 @@ -1,6 +1,6 @@ Metadata-Version: 1.2 Name: sushy -Version: 4.5.0 +Version: 4.5.1 Summary: Sushy is a small Python library to communicate with Redfish based systems Home-page: https://docs.openstack.org/sushy/latest/ Author: OpenStack diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/sushy.egg-info/SOURCES.txt new/sushy-4.5.1/sushy.egg-info/SOURCES.txt --- old/sushy-4.5.0/sushy.egg-info/SOURCES.txt 2023-05-11 11:12:15.000000000 +0200 +++ new/sushy-4.5.1/sushy.egg-info/SOURCES.txt 2023-08-24 10:59:33.000000000 +0200 @@ -42,6 +42,7 @@ releasenotes/notes/add-power-resource-e141ddf298673305.yaml releasenotes/notes/add-processor-id-and-status-b81d4c6e6c14c25f.yaml releasenotes/notes/add-raid-type-properties-2090da5bea37c660.yaml +releasenotes/notes/add-read-and-connect-timeout-9f7dc3ed63c192c8.yaml releasenotes/notes/add-response-cb-65d448ee2690d0b2.yaml releasenotes/notes/add-simple-storage-915464811737bb05.yaml releasenotes/notes/add-storage-and-simple-storage-attributes-to-system-16e81f9b15b1897d.yaml diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/sushy-4.5.0/sushy.egg-info/pbr.json new/sushy-4.5.1/sushy.egg-info/pbr.json --- old/sushy-4.5.0/sushy.egg-info/pbr.json 2023-05-11 11:12:15.000000000 +0200 +++ new/sushy-4.5.1/sushy.egg-info/pbr.json 2023-08-24 10:59:33.000000000 +0200 @@ -1 +1 @@ -{"git_version": "f03d77e", "is_release": true} \ No newline at end of file +{"git_version": "7c2a251", "is_release": true} \ No newline at end of file
