Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libnotify for openSUSE:Factory checked in at 2023-12-02 17:12:16 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libnotify (Old) and /work/SRC/openSUSE:Factory/.libnotify.new.25432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libnotify" Sat Dec 2 17:12:16 2023 rev:45 rq:1130317 version:0.8.3 Changes: -------- --- /work/SRC/openSUSE:Factory/libnotify/libnotify.changes 2023-02-25 19:54:47.727149642 +0100 +++ /work/SRC/openSUSE:Factory/.libnotify.new.25432/libnotify.changes 2023-12-02 17:12:27.199765545 +0100 @@ -1,0 +2,14 @@ +Tue Oct 10 14:08:33 UTC 2023 - Bjørn Lie <bjorn....@gmail.com> + +- Update to version 0.8.3: + + This release contains a critical stability/minor security + update which affects Electron applications that utilize Portal + notifications (eg, through Flatpak). It is highly recommended + that all users of libnotify 0.8.x update to this release. + + Please note that this fix has increased the minimum required + version of glib to 2.62.0. + + notification: + - Use g_signal_connect_object + - Move disconnect to dispose + +------------------------------------------------------------------- Old: ---- libnotify-0.8.2.tar.xz New: ---- libnotify-0.8.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libnotify.spec ++++++ --- /var/tmp/diff_new_pack.eNZ6SR/_old 2023-12-02 17:12:28.735821835 +0100 +++ /var/tmp/diff_new_pack.eNZ6SR/_new 2023-12-02 17:12:28.739821982 +0100 @@ -17,7 +17,7 @@ Name: libnotify -Version: 0.8.2 +Version: 0.8.3 Release: 0 Summary: Notifications Library License: LGPL-2.1-or-later @@ -33,7 +33,7 @@ BuildRequires: xsltproc BuildRequires: pkgconfig(gdk-pixbuf-2.0) BuildRequires: pkgconfig(gi-docgen) -BuildRequires: pkgconfig(glib-2.0) +BuildRequires: pkgconfig(glib-2.0) >= 2.62.0 BuildRequires: pkgconfig(gtk+-3.0) %description ++++++ libnotify-0.8.2.tar.xz -> libnotify-0.8.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.8.2/NEWS new/libnotify-0.8.3/NEWS --- old/libnotify-0.8.2/NEWS 2023-02-17 22:20:15.000000000 +0100 +++ new/libnotify-0.8.3/NEWS 2023-10-09 23:24:46.000000000 +0200 @@ -1,3 +1,20 @@ +New in 0.8.3 +============ + +This release contains a critical stability/minor security update which affects +Electron applications that utilize Portal notifications (eg, through Flatpak). +It is highly recommended that all users of libnotify 0.8.x update to this +release. + +Please note that this fix has increased the minimum required version of glib to +2.62.0. + +* notification: Use g_signal_connect_object (#34) [Maximiliano] +* notification: Move disconnect to dispose [Maximiliano] + +Contributors: + Maximiliano Sandoval R + New in 0.8.2 ============ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.8.2/libnotify/notification.c new/libnotify-0.8.3/libnotify/notification.c --- old/libnotify-0.8.2/libnotify/notification.c 2023-02-17 22:20:15.000000000 +0100 +++ new/libnotify-0.8.3/libnotify/notification.c 2023-10-09 23:24:46.000000000 +0200 @@ -397,12 +397,18 @@ { NotifyNotification *obj = NOTIFY_NOTIFICATION (object); NotifyNotificationPrivate *priv = obj->priv; + GDBusProxy *proxy; if (priv->portal_timeout_id) { g_source_remove (priv->portal_timeout_id); priv->portal_timeout_id = 0; } + proxy = _notify_get_proxy (NULL); + if (proxy != NULL) { + g_clear_signal_handler (&priv->proxy_signal_handler, proxy); + } + g_clear_object (&priv->icon_pixbuf); G_OBJECT_CLASS (parent_class)->dispose (object); @@ -413,7 +419,6 @@ { NotifyNotification *obj = NOTIFY_NOTIFICATION (object); NotifyNotificationPrivate *priv = obj->priv; - GDBusProxy *proxy; _notify_cache_remove_notification (obj); @@ -434,11 +439,6 @@ if (priv->hints != NULL) g_hash_table_destroy (priv->hints); - proxy = _notify_get_proxy (NULL); - if (proxy != NULL && priv->proxy_signal_handler != 0) { - g_signal_handler_disconnect (proxy, priv->proxy_signal_handler); - } - g_free (obj->priv); G_OBJECT_CLASS (parent_class)->finalize (object); @@ -684,20 +684,12 @@ return FALSE; } - /* Some clients have assumed it is safe to unref the - * Notification at the end of their NotifyActionCallback - * so we add a temporary ref until we're done with it. - */ - g_object_ref (notification); - notification->priv->activating = TRUE; pair->cb (notification, (char *) action, pair->user_data); notification->priv->activating = FALSE; g_free (notification->priv->activation_token); notification->priv->activation_token = NULL; - g_object_unref (notification); - return TRUE; } @@ -1107,10 +1099,11 @@ } if (priv->proxy_signal_handler == 0) { - priv->proxy_signal_handler = g_signal_connect (proxy, - "g-signal", - G_CALLBACK (proxy_g_signal_cb), - notification); + priv->proxy_signal_handler = g_signal_connect_object (proxy, + "g-signal", + G_CALLBACK (proxy_g_signal_cb), + notification, + 0); } if (_notify_uses_portal_notifications ()) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libnotify-0.8.2/meson.build new/libnotify-0.8.3/meson.build --- old/libnotify-0.8.2/meson.build 2023-02-17 22:20:15.000000000 +0100 +++ new/libnotify-0.8.3/meson.build 2023-10-09 23:24:46.000000000 +0200 @@ -1,6 +1,6 @@ project('libnotify', 'c', - version: '0.8.2', + version: '0.8.3', meson_version: '>= 0.56.0') gnome = import('gnome') @@ -39,7 +39,7 @@ libnotify_deps = [] extra_deps = [] -glib_req_version = '>= 2.38.0' +glib_req_version = '>= 2.62.0' gdk_pixbuf_dep = dependency('gdk-pixbuf-2.0') glib_dep = dependency('glib-2.0', version: glib_req_version)