Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package ade for openSUSE:Factory checked in at 2024-01-03 12:30:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ade (Old) and /work/SRC/openSUSE:Factory/.ade.new.28375 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ade" Wed Jan 3 12:30:03 2024 rev:5 rq:1136172 version:0.1.2d Changes: -------- --- /work/SRC/openSUSE:Factory/ade/ade.changes 2022-09-18 18:48:51.506520984 +0200 +++ /work/SRC/openSUSE:Factory/.ade.new.28375/ade.changes 2024-01-03 12:30:44.648092824 +0100 @@ -1,0 +2,12 @@ +Mon Jan 1 01:17:53 UTC 2024 - Stefan Brüns <stefan.bru...@rwth-aachen.de> + +- Update to version 0.1.2d + * Fix compilation with CXX standard set in parent project tree +- Update to version 0.1.2c + * Fixed issues with CMake exported targets/configs as part + of OpenVINO build + * Fixed GCC13 support +- Update to version 0.1.2b + * A minor version bump to fix warnings on Linux. + +------------------------------------------------------------------- Old: ---- ade-0.1.2a.tar.gz New: ---- ade-0.1.2d.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ade.spec ++++++ --- /var/tmp/diff_new_pack.N9fiaJ/_old 2024-01-03 12:30:45.604127789 +0100 +++ /var/tmp/diff_new_pack.N9fiaJ/_new 2024-01-03 12:30:45.604127789 +0100 @@ -23,7 +23,7 @@ %bcond_with tutorials Name: ade -Version: 0.1.2a +Version: 0.1.2d Release: 0 Summary: Graph construction, manipulation, and processing framework License: Apache-2.0 ++++++ ade-0.1.2a.tar.gz -> ade-0.1.2d.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/.github/workflows/workflow.yaml new/ade-0.1.2d/.github/workflows/workflow.yaml --- old/ade-0.1.2a/.github/workflows/workflow.yaml 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/.github/workflows/workflow.yaml 2023-10-10 10:08:15.000000000 +0200 @@ -14,6 +14,7 @@ os: [ ubuntu-20.04, ubuntu-22.04, + windows-2022, ] runs-on: ${{ matrix.os }} @@ -21,13 +22,24 @@ - uses: actions/checkout@v3 - name: Build Stage + shell: bash run: | mkdir build && cd build - cmake -DENABLE_ADE_TESTING=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=${{ matrix.version }} .. - make -j - - name: ADE-Test Stage - run: ./build/bin/ade-tests + if [ "$RUNNER_OS" == "Windows" ]; then + cmake -DENABLE_ADE_TESTING=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=${{ matrix.version }} .. + cmake --build . --target GTest --config Release + cmake --build . --config Release - - name: CMN-Test Stage - run: ./build/bin/common-tests \ No newline at end of file + elif [ "$RUNNER_OS" == "Linux" ]; then + cmake -DENABLE_ADE_TESTING=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=${{ matrix.version }} .. + make -j + + else + echo "$RUNNER_OS not supported" + exit 1 + fi + + - name: Test Stage + shell: bash + run: cd build && ctest -C Release diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/CMakeLists.txt new/ade-0.1.2d/CMakeLists.txt --- old/ade-0.1.2a/CMakeLists.txt 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/CMakeLists.txt 2023-10-10 10:08:15.000000000 +0200 @@ -4,7 +4,7 @@ # SPDX-License-Identifier: Apache-2.0 # -cmake_minimum_required(VERSION 3.2) +cmake_minimum_required(VERSION 3.5) project(ade) @@ -18,7 +18,7 @@ option(BUILD_ADE_DOCUMENTATION "Build doxygen documentation" OFF) option(BUILD_WITH_STATIC_CRT "Build with static multi-threaded C Runtime (MS Windows/Visual Studio only)" OFF) -set(CMAKE_CXX_STANDARD 11 CACHE STRING "C++ standard") +set(CMAKE_CXX_STANDARD 11) # TODO: this is horrible hack, we must follow cmake # build/install policy @@ -39,13 +39,18 @@ target_compile_options( ${target} PRIVATE -fstack-protector-strong) endif() elseif(WIN32) - target_compile_options( ${target} PRIVATE /GS /DynamicBase) - if(BUILD_WITH_STATIC_CRT) - target_compile_options( ${target} PRIVATE "/MT") - endif() - if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") - # These options for 32 bit builds only - target_compile_options( ${target} PRIVATE /SAFESEH /NXCOMPAT ) + if( ${CMAKE_CXX_COMPILER_ID} STREQUAL "MSVC") + target_compile_options( ${target} PRIVATE /GS /DynamicBase) + if(BUILD_WITH_STATIC_CRT) + target_compile_options( ${target} PRIVATE "/MT") + endif() + if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") + # These options for 32 bit builds only + target_compile_options( ${target} PRIVATE /SAFESEH /NXCOMPAT ) + endif() + elseif(${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") + target_compile_definitions( ${target} PRIVATE _FORTIFY_SOURCE=2 ) + target_compile_options( ${target} PRIVATE -fstack-protector-strong ) endif() endif() endfunction() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/README.md new/ade-0.1.2d/README.md --- old/ade-0.1.2a/README.md 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/README.md 2023-10-10 10:08:15.000000000 +0200 @@ -10,7 +10,7 @@ ## Prerequisites and building -The only prerequisites for library are CMake 3.2+ and a C++11 +The only prerequisites for library are CMake 3.5+ and a C++11 compiler. Building: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/sources/ade/CMakeLists.txt new/ade-0.1.2d/sources/ade/CMakeLists.txt --- old/ade-0.1.2a/sources/ade/CMakeLists.txt 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/sources/ade/CMakeLists.txt 2023-10-10 10:08:15.000000000 +0200 @@ -78,6 +78,8 @@ NO_SET_AND_CHECK_MACRO NO_CHECK_REQUIRED_COMPONENTS_MACRO) +export(TARGETS ade FILE "${CMAKE_BINARY_DIR}/adeTargets.cmake") + install(FILES "${CMAKE_BINARY_DIR}/adeConfig.cmake" "${CMAKE_BINARY_DIR}/adeConfigVersion.cmake" DESTINATION "${CMAKE_INSTALL_DATAROOTDIR}/ade" COMPONENT dev) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/sources/ade/include/ade/typed_graph.hpp new/ade-0.1.2d/sources/ade/include/ade/typed_graph.hpp --- old/ade-0.1.2a/sources/ade/include/ade/typed_graph.hpp 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/sources/ade/include/ade/typed_graph.hpp 2023-10-10 10:08:15.000000000 +0200 @@ -126,6 +126,14 @@ initIds(); } + // explicitly define copy-constructor since we modify operator= + ConstTypedGraph(const ConstTypedGraph<Types...>& other): + m_srcGraph(other.m_srcGraph) + { + details::checkUniqueNames<Types...>(); + initIds(); + } + template<typename... OtherTypes> ConstTypedGraph(const ConstTypedGraph<OtherTypes...>& other): m_srcGraph(other.m_srcGraph) @@ -175,6 +183,12 @@ ConstTypedGraph<Types...>(graph) { } + + // explicitly define copy-constructor since we modify operator= + TypedGraph(TypedGraph& graph): + ConstTypedGraph<Types...>(graph) + { + } template<typename... OtherTypes> TypedGraph(const TypedGraph<OtherTypes...>& other): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/ade-0.1.2a/sources/tests/CMakeLists.txt new/ade-0.1.2d/sources/tests/CMakeLists.txt --- old/ade-0.1.2a/sources/tests/CMakeLists.txt 2022-08-26 15:02:34.000000000 +0200 +++ new/ade-0.1.2d/sources/tests/CMakeLists.txt 2023-10-10 10:08:15.000000000 +0200 @@ -19,17 +19,26 @@ CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX:PATH=${GTEST_INSTALL_DIR} -Dgtest_force_shared_crt=ON LOG_DOWNLOAD ON LOG_CONFIGURE ON - LOG_BUILD ON) + LOG_BUILD ON + ) set(GTEST_LIBRARIES_PATH ${GTEST_INSTALL_DIR}/lib/) - set(GTEST_LIBRARY_PATH ${GTEST_LIBRARIES_PATH}/${CMAKE_FIND_LIBRARY_PREFIXES}gtest${CMAKE_STATIC_LIBRARY_SUFFIX}) + set(GTEST_LIB_PREFIX ${CMAKE_FIND_LIBRARY_PREFIXES}) + if( WIN32 AND ${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") + # Somehow in this case we get GTest compiled as gtest.lib and + # prefix equals to "pub;" + # Workarounds, workarounds... + set(GTEST_LIB_PREFIX "") + endif() + + set(GTEST_LIBRARY_PATH ${GTEST_LIBRARIES_PATH}/${GTEST_LIB_PREFIX}gtest${CMAKE_STATIC_LIBRARY_SUFFIX}) set(GTEST_LIBRARY gtest) add_library(${GTEST_LIBRARY} UNKNOWN IMPORTED) set_property(TARGET ${GTEST_LIBRARY} PROPERTY IMPORTED_LOCATION ${GTEST_LIBRARY_PATH}) add_dependencies(${GTEST_LIBRARY} GTest) - set(GTEST_MAIN_LIBRARY_PATH ${GTEST_LIBRARIES_PATH}/${CMAKE_FIND_LIBRARY_PREFIXES}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX}) + set(GTEST_MAIN_LIBRARY_PATH ${GTEST_LIBRARIES_PATH}/${GTEST_LIB_PREFIX}gtest_main${CMAKE_STATIC_LIBRARY_SUFFIX}) set(GTEST_MAIN_LIBRARY gtest-main) add_library(${GTEST_MAIN_LIBRARY} UNKNOWN IMPORTED) set_property(TARGET ${GTEST_MAIN_LIBRARY} PROPERTY IMPORTED_LOCATION ${GTEST_MAIN_LIBRARY_PATH})