Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libstorage-ng for openSUSE:Factory checked in at 2024-01-12 23:44:54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libstorage-ng (Old) and /work/SRC/openSUSE:Factory/.libstorage-ng.new.21961 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libstorage-ng" Fri Jan 12 23:44:54 2024 rev:254 rq:1138154 version:4.5.172 Changes: -------- --- /work/SRC/openSUSE:Factory/libstorage-ng/libstorage-ng.changes 2024-01-10 21:51:04.217512552 +0100 +++ /work/SRC/openSUSE:Factory/.libstorage-ng.new.21961/libstorage-ng.changes 2024-01-12 23:45:10.758054421 +0100 @@ -1,0 +2,10 @@ +Thu Jan 11 15:53:48 UTC 2024 - aschn...@suse.com + +- merge gh#openSUSE/libstorage-ng#978 +- added get_linux_partition_id() taking Arch parameter +- make git ignore javascript in generated documentation +- coding style +- cleanup +- 4.5.172 + +-------------------------------------------------------------------- Old: ---- libstorage-ng-4.5.171.tar.xz New: ---- libstorage-ng-4.5.172.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libstorage-ng.spec ++++++ --- /var/tmp/diff_new_pack.KV6PuA/_old 2024-01-12 23:45:12.362113130 +0100 +++ /var/tmp/diff_new_pack.KV6PuA/_new 2024-01-12 23:45:12.386114008 +0100 @@ -18,7 +18,7 @@ %define libname %{name}1 Name: libstorage-ng -Version: 4.5.171 +Version: 4.5.172 Release: 0 Summary: Library for storage management License: GPL-2.0-only ++++++ libstorage-ng-4.5.171.tar.xz -> libstorage-ng-4.5.172.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/LIBVERSION new/libstorage-ng-4.5.172/LIBVERSION --- old/libstorage-ng-4.5.171/LIBVERSION 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/LIBVERSION 2024-01-11 16:53:48.000000000 +0100 @@ -1 +1 @@ -1.97.0 +1.98.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/VERSION new/libstorage-ng-4.5.172/VERSION --- old/libstorage-ng-4.5.171/VERSION 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/VERSION 2024-01-11 16:53:48.000000000 +0100 @@ -1 +1 @@ -4.5.171 +4.5.172 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/bindings/storage-catches.i new/libstorage-ng-4.5.172/bindings/storage-catches.i --- old/libstorage-ng-4.5.171/bindings/storage-catches.i 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/bindings/storage-catches.i 2024-01-11 16:53:48.000000000 +0100 @@ -40,6 +40,7 @@ %exceptionclass storage::WrongNumberOfHolders; %exceptionclass storage::WrongNumberOfParents; +%catches(storage::Exception) storage::get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, const Arch &arch); %catches(storage::Exception) storage::get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, SystemInfo &system_info); %catches(storage::ParseException, storage::OverflowException) storage::humanstring_to_byte(const std::string &str, bool classic); %catches(storage::NullPointerException) storage::is_bcache(const Device *device); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/doc/autodocs/html/.gitignore new/libstorage-ng-4.5.172/doc/autodocs/html/.gitignore --- old/libstorage-ng-4.5.171/doc/autodocs/html/.gitignore 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/doc/autodocs/html/.gitignore 2024-01-11 16:53:48.000000000 +0100 @@ -1,6 +1,7 @@ *.css *.gif *.html +*.js *.map *.md5 *.png diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/integration-tests/partitions/linux-root-id.py new/libstorage-ng-4.5.172/integration-tests/partitions/linux-root-id.py --- old/libstorage-ng-4.5.171/integration-tests/partitions/linux-root-id.py 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/integration-tests/partitions/linux-root-id.py 2024-01-11 16:53:48.000000000 +0100 @@ -15,3 +15,10 @@ print(get_linux_partition_id(LinuxPartitionIdCategory_ROOT, system_info)) +environment = Environment(False) + +storage = Storage(environment) +storage.probe() + +print(get_linux_partition_id(LinuxPartitionIdCategory_ROOT, storage.get_arch())) + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Actiongraph.cc new/libstorage-ng-4.5.172/storage/Actiongraph.cc --- old/libstorage-ng-4.5.171/storage/Actiongraph.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Actiongraph.cc 2024-01-11 16:53:48.000000000 +0100 @@ -35,9 +35,7 @@ } - Actiongraph::~Actiongraph() - { - } + Actiongraph::~Actiongraph() = default; const Storage& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/ActiongraphImpl.cc new/libstorage-ng-4.5.172/storage/ActiongraphImpl.cc --- old/libstorage-ng-4.5.171/storage/ActiongraphImpl.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/ActiongraphImpl.cc 2024-01-11 16:53:48.000000000 +0100 @@ -65,9 +65,7 @@ } - CommitData::~CommitData() - { - } + CommitData::~CommitData() = default; EtcFstab& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Devicegraph.cc new/libstorage-ng-4.5.172/storage/Devicegraph.cc --- old/libstorage-ng-4.5.171/storage/Devicegraph.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Devicegraph.cc 2024-01-11 16:53:48.000000000 +0100 @@ -122,9 +122,7 @@ } - Devicegraph::~Devicegraph() - { - } + Devicegraph::~Devicegraph() = default; bool diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Devices/Device.cc new/libstorage-ng-4.5.172/storage/Devices/Device.cc --- old/libstorage-ng-4.5.171/storage/Devices/Device.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Devices/Device.cc 2024-01-11 16:53:48.000000000 +0100 @@ -47,9 +47,7 @@ } - Device::~Device() - { - } + Device::~Device() = default; string diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Devices/Partition.cc new/libstorage-ng-4.5.172/storage/Devices/Partition.cc --- old/libstorage-ng-4.5.171/storage/Devices/Partition.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Devices/Partition.cc 2024-01-11 16:53:48.000000000 +0100 @@ -1,6 +1,6 @@ /* * Copyright (c) [2014-2015] Novell, Inc. - * Copyright (c) [2016-2023] SUSE LLC + * Copyright (c) [2016-2024] SUSE LLC * * All Rights Reserved. * @@ -115,13 +115,12 @@ IdNum - get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, SystemInfo& system_info) + get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, const Arch& arch) { - const string& arch = system_info.get_impl().getArch().get_arch(); - for (const IdInfo& id_info : id_info_registry) { - if (id_info.linux_partition_id_category == linux_partition_id_category && regex_match(arch, id_info.arch)) + if (id_info.linux_partition_id_category == linux_partition_id_category && + regex_match(arch.get_arch(), id_info.arch)) return id_info.id; } @@ -129,6 +128,13 @@ } + IdNum + get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, SystemInfo& system_info) + { + return get_linux_partition_id(linux_partition_id_category, system_info.get_impl().getArch()); + } + + Partition* Partition::create(Devicegraph* devicegraph, const string& name, const Region& region, PartitionType type) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Devices/Partition.h new/libstorage-ng-4.5.172/storage/Devices/Partition.h --- old/libstorage-ng-4.5.171/storage/Devices/Partition.h 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Devices/Partition.h 2024-01-11 16:53:48.000000000 +0100 @@ -1,6 +1,6 @@ /* * Copyright (c) [2014-2015] Novell, Inc. - * Copyright (c) [2016-2023] SUSE LLC + * Copyright (c) [2016-2024] SUSE LLC * * All Rights Reserved. * @@ -34,6 +34,7 @@ class PartitionTable; class Partitionable; class SystemInfo; + class Arch; /** @@ -252,6 +253,17 @@ /** + * Get the partition id for the Linux partition of the given category (root, usr, ...) + * depending on the architecture. + * + * @see IdNum, LinuxPartitionIdCategory + * + * @throw Exception + */ + IdNum get_linux_partition_id(LinuxPartitionIdCategory linux_partition_id_category, const Arch& arch); + + + /** * Get the partition id for the Linux partition of the given category (root, usr, ...) * depending on the architecture. * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Environment.cc new/libstorage-ng-4.5.172/storage/Environment.cc --- old/libstorage-ng-4.5.171/storage/Environment.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Environment.cc 2024-01-11 16:53:48.000000000 +0100 @@ -48,9 +48,7 @@ } - Environment::~Environment() - { - } + Environment::~Environment() = default; bool diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Filesystems/BtrfsQgroupImpl.cc new/libstorage-ng-4.5.172/storage/Filesystems/BtrfsQgroupImpl.cc --- old/libstorage-ng-4.5.171/storage/Filesystems/BtrfsQgroupImpl.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Filesystems/BtrfsQgroupImpl.cc 2024-01-11 16:53:48.000000000 +0100 @@ -72,11 +72,6 @@ } - BtrfsQgroup::Impl::~Impl() - { - } - - bool BtrfsQgroup::Impl::is_in_view(View view) const { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Filesystems/BtrfsQgroupImpl.h new/libstorage-ng-4.5.172/storage/Filesystems/BtrfsQgroupImpl.h --- old/libstorage-ng-4.5.171/storage/Filesystems/BtrfsQgroupImpl.h 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Filesystems/BtrfsQgroupImpl.h 2024-01-11 16:53:48.000000000 +0100 @@ -62,8 +62,6 @@ Impl(const id_t& id); - virtual ~Impl(); - Impl(const xmlNode* node); virtual bool is_in_view(View view) const override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Holders/Holder.cc new/libstorage-ng-4.5.172/storage/Holders/Holder.cc --- old/libstorage-ng-4.5.171/storage/Holders/Holder.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Holders/Holder.cc 2024-01-11 16:53:48.000000000 +0100 @@ -45,9 +45,7 @@ } - Holder::~Holder() - { - } + Holder::~Holder() = default; bool diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Pool.cc new/libstorage-ng-4.5.172/storage/Pool.cc --- old/libstorage-ng-4.5.171/storage/Pool.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Pool.cc 2024-01-11 16:53:48.000000000 +0100 @@ -42,9 +42,7 @@ } - Pool::~Pool() - { - } + Pool::~Pool() = default; const map<string, string>& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Storage.cc new/libstorage-ng-4.5.172/storage/Storage.cc --- old/libstorage-ng-4.5.171/storage/Storage.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Storage.cc 2024-01-11 16:53:48.000000000 +0100 @@ -37,9 +37,7 @@ } - LuksInfo::~LuksInfo() - { - } + LuksInfo::~LuksInfo() = default; const string& @@ -90,9 +88,7 @@ } - BitlockerInfo::~BitlockerInfo() - { - } + BitlockerInfo::~BitlockerInfo() = default; const string& @@ -142,9 +138,7 @@ } - DeactivateStatusV2::~DeactivateStatusV2() - { - } + DeactivateStatusV2::~DeactivateStatusV2() = default; DeactivateStatusV2& @@ -203,9 +197,7 @@ } - Storage::~Storage() - { - } + Storage::~Storage() = default; const Environment& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Storage.h new/libstorage-ng-4.5.172/storage/Storage.h --- old/libstorage-ng-4.5.171/storage/Storage.h 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Storage.h 2024-01-11 16:53:48.000000000 +0100 @@ -456,6 +456,10 @@ public: const Environment& get_environment() const; + + /** + * So far only valid after probing. + */ const Arch& get_arch() const; /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/SystemInfo/SystemInfo.cc new/libstorage-ng-4.5.172/storage/SystemInfo/SystemInfo.cc --- old/libstorage-ng-4.5.171/storage/SystemInfo/SystemInfo.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/SystemInfo/SystemInfo.cc 2024-01-11 16:53:48.000000000 +0100 @@ -32,8 +32,6 @@ } - SystemInfo::~SystemInfo() - { - } + SystemInfo::~SystemInfo() = default; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Utils/Alignment.cc new/libstorage-ng-4.5.172/storage/Utils/Alignment.cc --- old/libstorage-ng-4.5.171/storage/Utils/Alignment.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Utils/Alignment.cc 2024-01-11 16:53:48.000000000 +0100 @@ -47,9 +47,7 @@ } - Alignment::~Alignment() - { - } + Alignment::~Alignment() = default; Alignment& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Utils/Region.cc new/libstorage-ng-4.5.172/storage/Utils/Region.cc --- old/libstorage-ng-4.5.171/storage/Utils/Region.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Utils/Region.cc 2024-01-11 16:53:48.000000000 +0100 @@ -88,9 +88,7 @@ } - Region::~Region() - { - } + Region::~Region() = default; Region& diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libstorage-ng-4.5.171/storage/Utils/Topology.cc new/libstorage-ng-4.5.172/storage/Utils/Topology.cc --- old/libstorage-ng-4.5.171/storage/Utils/Topology.cc 2024-01-09 12:22:39.000000000 +0100 +++ new/libstorage-ng-4.5.172/storage/Utils/Topology.cc 2024-01-11 16:53:48.000000000 +0100 @@ -45,9 +45,7 @@ } - Topology::~Topology() - { - } + Topology::~Topology() = default; Topology&