Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package gstreamer-plugins-bad for
openSUSE:Factory checked in at 2024-03-13 22:16:44
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gstreamer-plugins-bad (Old)
and /work/SRC/openSUSE:Factory/.gstreamer-plugins-bad.new.1770 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gstreamer-plugins-bad"
Wed Mar 13 22:16:44 2024 rev:166 rq:1157153 version:1.24.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/gstreamer-plugins-bad/gstreamer-plugins-bad.changes
2024-03-06 23:03:48.703747144 +0100
+++
/work/SRC/openSUSE:Factory/.gstreamer-plugins-bad.new.1770/gstreamer-plugins-bad.changes
2024-03-13 22:17:10.701181088 +0100
@@ -1,0 +2,8 @@
+Tue Mar 12 09:36:29 UTC 2024 - Antonio Larrosa <alarr...@suse.com>
+
+- Add patch that fixes a crash when initializing gstva, submitted
+ to upstream at
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6319
+ (boo#1221150):
+ * 0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch
+
+-------------------------------------------------------------------
New:
----
0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch
BETA DEBUG BEGIN:
New: (boo#1221150):
* 0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ gstreamer-plugins-bad.spec ++++++
--- /var/tmp/diff_new_pack.JBnfgL/_old 2024-03-13 22:17:12.149234360 +0100
+++ /var/tmp/diff_new_pack.JBnfgL/_new 2024-03-13 22:17:12.149234360 +0100
@@ -96,6 +96,8 @@
Patch0: fix-build-with-srt-1.3.4.patch
# PATCH-FIX-OPENSUSE spandsp3.patch jeng...@inai.de -- Fix build against
spandsp 3.x. Patch is not upstreamable in this form
Patch2: spandsp3.patch
+# PATCH-FIX-UPSTREAM 0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch
alarr...@suse.com -- Fix crash (boo#1221150)
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6319
+Patch3: 0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch
%if %{with fdk_aac}
BuildRequires: pkgconfig(fdk-aac) >= 0.1.4
@@ -822,6 +824,7 @@
%if %{pkg_vcmp spandsp-devel >= 3}
%patch -P 2 -p1
%endif
+%patch -P 3 -p1
%build
%global optflags %{optflags} -fcommon
++++++ 0001-Move-PROP_RATE_CONTROL-to-the-end-of-the-array.patch ++++++
>From 4897c4c56cf09ca432a6825f689c0571d7a789f8 Mon Sep 17 00:00:00 2001
From: Antonio Larrosa <alarr...@suse.com>
Date: Mon, 11 Mar 2024 12:42:48 +0100
Subject: [PATCH] Move PROP_RATE_CONTROL to the end of the array
This fixes a crash in `gst_va_h264_enc_class_init` and
`gst_va_h265_enc_class_init`
(and probably also in gst_va_av1_enc_class_init) when calling
`g_object_class_install_properties (object_class, n_props, properties);`
When rate_control_type is 0, the following code is executed in :
```
} else {
n_props--;
properties[PROP_RATE_CONTROL] = NULL;
}
```
n_props has initially a value of N_PROPERTIES but PROP_RATE_CONTROL
is not the last element in the array, so it's making
g_object_class_install_properties fail to iterate over the
properties array.
This applies the same fix to gstvah264enc.c and gstvah265enc.c .
---
subprojects/gst-plugins-bad/sys/va/gstvaav1enc.c | 2 +-
subprojects/gst-plugins-bad/sys/va/gstvah264enc.c | 2 +-
subprojects/gst-plugins-bad/sys/va/gstvah265enc.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys/va/gstvaav1enc.c b/sys/va/gstvaav1enc.c
index 5050d8593cc..fa27fa6f760 100644
--- a/sys/va/gstvaav1enc.c
+++ b/sys/va/gstvaav1enc.c
@@ -86,11 +86,11 @@ enum
PROP_TARGET_PERCENTAGE,
PROP_TARGET_USAGE,
PROP_CPB_SIZE,
- PROP_RATE_CONTROL,
PROP_NUM_TILE_COLS,
PROP_NUM_TILE_ROWS,
PROP_TILE_GROUPS,
PROP_MBBRC,
+ PROP_RATE_CONTROL,
N_PROPERTIES
};
diff --git a/sys/va/gstvah264enc.c b/sys/va/gstvah264enc.c
index 81faec3d367..4fb4ae9d535 100644
--- a/sys/va/gstvah264enc.c
+++ b/sys/va/gstvah264enc.c
@@ -100,10 +100,10 @@ enum
PROP_BITRATE,
PROP_TARGET_PERCENTAGE,
PROP_TARGET_USAGE,
- PROP_RATE_CONTROL,
PROP_CPB_SIZE,
PROP_AUD,
PROP_CC,
+ PROP_RATE_CONTROL,
N_PROPERTIES
};
diff --git a/sys/va/gstvah265enc.c b/sys/va/gstvah265enc.c
index 9bcad7f07ac..793d0c5f091 100644
--- a/sys/va/gstvah265enc.c
+++ b/sys/va/gstvah265enc.c
@@ -88,11 +88,11 @@ enum
PROP_BITRATE,
PROP_TARGET_PERCENTAGE,
PROP_TARGET_USAGE,
- PROP_RATE_CONTROL,
PROP_CPB_SIZE,
PROP_AUD,
PROP_NUM_TILE_COLS,
PROP_NUM_TILE_ROWS,
+ PROP_RATE_CONTROL,
N_PROPERTIES
};
--
GitLab
