Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package osmo-ggsn for openSUSE:Factory checked in at 2024-04-12 17:35:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/osmo-ggsn (Old) and /work/SRC/openSUSE:Factory/.osmo-ggsn.new.26366 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "osmo-ggsn" Fri Apr 12 17:35:02 2024 rev:12 rq:1166992 version:1.11.0 Changes: -------- --- /work/SRC/openSUSE:Factory/osmo-ggsn/osmo-ggsn.changes 2023-11-02 20:22:07.625286566 +0100 +++ /work/SRC/openSUSE:Factory/.osmo-ggsn.new.26366/osmo-ggsn.changes 2024-04-12 17:40:23.792152155 +0200 @@ -1,0 +2,6 @@ +Thu Apr 11 23:46:02 UTC 2024 - Jan Engelhardt <jeng...@inai.de> + +- Update to release 1.11.0 + * gtp: Add net GTP cause values and a function to check for success + +------------------------------------------------------------------- Old: ---- 1.10.2.tar.gz New: ---- 1.11.0.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ osmo-ggsn.spec ++++++ --- /var/tmp/diff_new_pack.tzqPM7/_old 2024-04-12 17:40:24.236168508 +0200 +++ /var/tmp/diff_new_pack.tzqPM7/_new 2024-04-12 17:40:24.236168508 +0200 @@ -1,7 +1,7 @@ # # spec file for package osmo-ggsn # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,7 +19,7 @@ %define _lto_cflags %nil Name: osmo-ggsn %define lname libgtp6 -Version: 1.10.2 +Version: 1.11.0 Release: 0 Summary: GPRS Support Node License: GPL-2.0-only AND LGPL-2.1-or-later ++++++ 1.10.2.tar.gz -> 1.11.0.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/osmo-ggsn-1.10.2/debian/changelog new/osmo-ggsn-1.11.0/debian/changelog --- old/osmo-ggsn-1.10.2/debian/changelog 2023-09-12 14:36:11.000000000 +0200 +++ new/osmo-ggsn-1.11.0/debian/changelog 2023-11-28 14:07:17.000000000 +0100 @@ -1,3 +1,10 @@ +osmo-ggsn (1.11.0) unstable; urgency=medium + + [ Daniel Willmann ] + * gtp: Add net GTP cause values and a function to check for success + + -- Oliver Smith <osm...@sysmocom.de> Tue, 28 Nov 2023 13:38:29 +0100 + osmo-ggsn (1.10.2) unstable; urgency=medium [ Vadim Yanitskiy ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/osmo-ggsn-1.10.2/gtp/Makefile.am new/osmo-ggsn-1.11.0/gtp/Makefile.am --- old/osmo-ggsn-1.10.2/gtp/Makefile.am 2023-09-12 14:36:11.000000000 +0200 +++ new/osmo-ggsn-1.11.0/gtp/Makefile.am 2023-11-28 14:07:17.000000000 +0100 @@ -2,7 +2,7 @@ # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html # If major=current-age is increased, remember to update the dh_strip line in debian/rules! -LIBVERSION=9:0:3 +LIBVERSION=9:1:3 lib_LTLIBRARIES = libgtp.la diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/osmo-ggsn-1.10.2/gtp/gtp.c new/osmo-ggsn-1.11.0/gtp/gtp.c --- old/osmo-ggsn-1.10.2/gtp/gtp.c 2023-09-12 14:36:11.000000000 +0200 +++ new/osmo-ggsn-1.11.0/gtp/gtp.c 2023-11-28 14:07:17.000000000 +0100 @@ -995,7 +995,7 @@ /* Now send off a reply to the peer */ gtp_create_pdp_resp(gsn, pdp->version, pdp, cause); - if (cause != GTPCAUSE_ACC_REQ) + if (!gtp_cause_successful(cause)) gtp_freepdp(gsn, pdp); return 0; @@ -1011,7 +1011,7 @@ gtpie_tv1(&packet, &length, GTP_MAX, GTPIE_CAUSE, cause); - if (cause == GTPCAUSE_ACC_REQ) { + if (gtp_cause_successful(cause)) { if (version == 0) gtpie_tv0(&packet, &length, GTP_MAX, GTPIE_QOS_PROFILE0, @@ -1445,7 +1445,7 @@ } /* Check all conditional information elements */ - if (GTPCAUSE_ACC_REQ == cause) { + if (gtp_cause_successful(cause)) { if (version == 0) { if (gtpie_gettv0(ie, GTPIE_QOS_PROFILE0, 0, @@ -1667,7 +1667,7 @@ gtpie_tv1(&packet, &length, GTP_MAX, GTPIE_CAUSE, cause); - if (cause == GTPCAUSE_ACC_REQ) { + if (gtp_cause_successful(cause)) { if (version == 0) gtpie_tv0(&packet, &length, GTP_MAX, GTPIE_QOS_PROFILE0, @@ -1997,7 +1997,7 @@ /* Check all conditional information elements */ /* TODO: This does not handle GGSN-initiated update responses */ - if (cause == GTPCAUSE_ACC_REQ) { + if (gtp_cause_successful(cause)) { if (version == 0) { if (gtpie_gettv0(ie, GTPIE_QOS_PROFILE0, 0, &pdp->qos_neg0, @@ -2172,7 +2172,7 @@ gtp_resp(version, gsn, pdp, &packet, length, peer, fd, get_seq(pack), get_tid(pack)); - if (cause == GTPCAUSE_ACC_REQ) { + if (gtp_cause_successful(cause)) { if ((teardown) || (version == 0)) { /* Remove all contexts */ gtp_freepdp_teardown(gsn, linked_pdp); } else { @@ -2198,7 +2198,6 @@ } } } - /* if (cause == GTPCAUSE_ACC_REQ) */ return 0; } @@ -2350,7 +2349,7 @@ } /* Check the cause value (again) */ - if ((GTPCAUSE_ACC_REQ != cause) && (GTPCAUSE_NON_EXIST != cause)) { + if (!gtp_cause_successful(cause) && (GTPCAUSE_NON_EXIST != cause)) { rate_ctr_inc2(gsn->ctrg, GSN_CTR_ERR_UNEXPECTED_CAUSE); GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Unexpected cause value received: %d\n", cause); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/osmo-ggsn-1.10.2/gtp/gtp.h new/osmo-ggsn-1.11.0/gtp/gtp.h --- old/osmo-ggsn-1.10.2/gtp/gtp.h 2023-09-12 14:36:11.000000000 +0200 +++ new/osmo-ggsn-1.11.0/gtp/gtp.h 2023-11-28 14:07:17.000000000 +0100 @@ -103,7 +103,9 @@ #define GTPCAUSE_049 49 /* Cause values reserved for GPRS charging protocol use (See GTP' in GSM 12.15) 49-63 */ #define GTPCAUSE_064 64 /* For future use 64-127 */ #define GTPCAUSE_ACC_REQ 128 /* Request accepted */ -#define GTPCAUSE_129 129 /* For future use 129-176 */ +#define GTPCAUSE_NEW_PDP_NET_PREF 129 /* New PDP type due to network preference */ +#define GTPCAUSE_NEW_PDP_ADDR_BEAR 130 /* New PDP type due to single address bearer only */ +#define GTPCAUSE_131 131 /* For future use 131-176 */ #define GTPCAUSE_177 177 /* Cause values reserved for GPRS charging protocol use (See GTP' In GSM 12.15) 177-191 */ #define GTPCAUSE_NON_EXIST 192 /* Non-existent */ #define GTPCAUSE_INVALID_MESSAGE 193 /* Invalid message format */ @@ -137,6 +139,13 @@ #define GTPCAUSE_221 221 /* For Future Use 221-240 */ #define GTPCAUSE_241 241 /* Cause Values Reserved For Gprs Charging Protocol Use (See Gtp' In Gsm 12.15) 241-255 */ +static inline bool gtp_cause_successful(uint8_t cause) +{ + return cause == GTPCAUSE_ACC_REQ || + cause == GTPCAUSE_NEW_PDP_NET_PREF || + cause == GTPCAUSE_NEW_PDP_ADDR_BEAR; +} + struct ul66_t; struct ul16_t; struct pdp_t;
