Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package fde-tools for openSUSE:Factory
checked in at 2024-05-07 18:02:22
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/fde-tools (Old)
and /work/SRC/openSUSE:Factory/.fde-tools.new.1880 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "fde-tools"
Tue May 7 18:02:22 2024 rev:21 rq:1172318 version:0.7.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/fde-tools/fde-tools.changes 2024-04-21
20:24:59.320874521 +0200
+++ /work/SRC/openSUSE:Factory/.fde-tools.new.1880/fde-tools.changes
2024-05-07 18:02:26.768417733 +0200
@@ -1,0 +2,6 @@
+Tue May 7 05:53:20 UTC 2024 - Gary Ching-Pang Lin <g...@suse.com>
+
+- Add fde-tools-bsc1223771-firstboot-make-Pass-phrase-mandatory.patch
+ to make "pass" mandatory during firstboot (bsc#1223771)
+
+-------------------------------------------------------------------
New:
----
fde-tools-bsc1223771-firstboot-make-Pass-phrase-mandatory.patch
BETA DEBUG BEGIN:
New:
- Add fde-tools-bsc1223771-firstboot-make-Pass-phrase-mandatory.patch
to make "pass" mandatory during firstboot (bsc#1223771)
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ fde-tools.spec ++++++
--- /var/tmp/diff_new_pack.NylBwR/_old 2024-05-07 18:02:27.392440423 +0200
+++ /var/tmp/diff_new_pack.NylBwR/_new 2024-05-07 18:02:27.396440569 +0200
@@ -37,6 +37,7 @@
Patch5: fde-tools-bsc1223002-firstboot-disable-ccid.patch
Patch6:
fde-tools-bsc1218390-Switch-to-target-platform-when-available.patch
Patch7:
fde-tools-bsc1218390-fix-tpm-present-with-the-newer-pcr-oracle.patch
+Patch8: fde-tools-bsc1223771-firstboot-make-Pass-phrase-mandatory.patch
BuildRequires: help2man
BuildRequires: pkgconfig(json-c)
BuildRequires: pkgconfig(libcryptsetup)
++++++ fde-tools-bsc1223771-firstboot-make-Pass-phrase-mandatory.patch ++++++
>From e0222c3dcf0bb1a44328b893bed9224d05b7506a Mon Sep 17 00:00:00 2001
From: Gary Lin <g...@suse.com>
Date: Mon, 6 May 2024 16:28:41 +0800
Subject: [PATCH] firstboot: make "Pass phrase" mandatory
Without choosing the "Pass phrase" option, the default VM password will
remain after firstboot. To ensure the default password is gone for good,
make "Pass phrase" mandatory.
Signed-off-by: Gary Lin <g...@suse.com>
---
firstboot/fde | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/firstboot/fde b/firstboot/fde
index 4911b32..161e832 100755
--- a/firstboot/fde
+++ b/firstboot/fde
@@ -203,15 +203,22 @@ function fde_setup_unencrypted {
function __fde_valid_protections {
+ pass_warn=true
for tag in $*; do
case $tag in
- pass|tpm) : ;;
+ pass) pass_warn=false ;;
+ tpm) : ;;
*)
display_errorbox "FDE key protection scheme $tag not yet
implemented"
return 1;;
esac
done
+ if $pass_warn; then
+ display_errorbox "Pass phrase is mandatory"
+ return 1
+ fi
+
return 0
}
@@ -253,10 +260,6 @@ function fde_choose_protection {
FDE_PROTECTION="$result"
fde_trace "user selected protections: <$FDE_PROTECTION>"
- if [ -z "$FDE_PROTECTION" ]; then
- return 1
- fi
-
if __fde_valid_protections $FDE_PROTECTION; then
break
fi
--
2.35.3
