Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package schismtracker for openSUSE:Factory
checked in at 2024-05-17 20:06:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/schismtracker (Old)
and /work/SRC/openSUSE:Factory/.schismtracker.new.1880 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "schismtracker"
Fri May 17 20:06:06 2024 rev:34 rq:1174755 version:20240515
Changes:
--------
--- /work/SRC/openSUSE:Factory/schismtracker/schismtracker.changes
2024-05-16 17:18:23.278908571 +0200
+++ /work/SRC/openSUSE:Factory/.schismtracker.new.1880/schismtracker.changes
2024-05-17 20:07:26.896337317 +0200
@@ -1,0 +2,5 @@
+Fri May 17 05:57:18 UTC 2024 - Jan Engelhardt <jeng...@inai.de>
+
+- Add 0001-player-fx-check-for-Instrument-Mode-when-handling-No.patch
+
+-------------------------------------------------------------------
New:
----
0001-player-fx-check-for-Instrument-Mode-when-handling-No.patch
BETA DEBUG BEGIN:
New:
- Add 0001-player-fx-check-for-Instrument-Mode-when-handling-No.patch
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ schismtracker.spec ++++++
--- /var/tmp/diff_new_pack.JJdmtm/_old 2024-05-17 20:07:27.464357841 +0200
+++ /var/tmp/diff_new_pack.JJdmtm/_new 2024-05-17 20:07:27.464357841 +0200
@@ -28,6 +28,7 @@
Patch1: schism-alsa.diff
Patch2: schism-nodate.diff
Patch3: schism-deptrack.diff
+Patch4: 0001-player-fx-check-for-Instrument-Mode-when-handling-No.patch
BuildRequires: alsa-devel
BuildRequires: autoconf
BuildRequires: automake
++++++ 0001-player-fx-check-for-Instrument-Mode-when-handling-No.patch ++++++
>From 943993a1c038c43dd9c3c326fe9f981eeb6c4fcf Mon Sep 17 00:00:00 2001
From: Paper <pa...@paper.us.eu.org>
Date: Thu, 16 May 2024 22:23:16 -0400
Subject: [PATCH] player/fx: check for Instrument Mode when handling
NoMapEffects.it
Fixes #437. Simple fix, annoying though :)
---
player/effects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/player/effects.c b/player/effects.c
index 814fff29..31c5239e 100644
--- a/player/effects.c
+++ b/player/effects.c
@@ -2153,7 +2153,7 @@ void csf_process_effects(song_t *csf, int firsttick)
// This is probably the single biggest WTF replayer bug in
Impulse Tracker.
// In instrument mode, when an note + instrument is triggered
that does not map to any sample, the entire cell (including potentially present
global effects!)
// is ignored. Even better, if on a following row another
instrument number (this time without a note) is encountered, we end up in the
same situation!
- if (instr > 0 && instr < MAX_INSTRUMENTS &&
csf->instruments[instr] != NULL)
+ if (csf->flags & SONG_INSTRUMENTMODE && instr > 0 && instr <
MAX_INSTRUMENTS && csf->instruments[instr] != NULL)
{
uint8_t note = (chan->row_note != NOTE_NONE) ?
chan->row_note : chan->new_note;
if (NOTE_IS_NOTE(note) &&
csf->instruments[instr]->sample_map[note - NOTE_FIRST] == 0)
--
2.45.0
