Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libsidplayfp for openSUSE:Factory checked in at 2024-05-21 18:35:09 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libsidplayfp (Old) and /work/SRC/openSUSE:Factory/.libsidplayfp.new.1880 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libsidplayfp" Tue May 21 18:35:09 2024 rev:12 rq:1175308 version:2.7.1 Changes: -------- --- /work/SRC/openSUSE:Factory/libsidplayfp/libsidplayfp.changes 2024-04-02 16:42:41.161740179 +0200 +++ /work/SRC/openSUSE:Factory/.libsidplayfp.new.1880/libsidplayfp.changes 2024-05-21 18:35:30.604340017 +0200 @@ -1,0 +2,9 @@ +Sun May 19 12:52:40 UTC 2024 - Martin Hauke <mar...@gmx.de> + +- Update to version 2.7.1 + * Sync resid with upstream. + * Make strong CWs the default. + * Downtune the leakage parameter a bit. + * Fix UBSan complaint abount uninitialized var 'is6581'. + +------------------------------------------------------------------- Old: ---- libsidplayfp-2.7.0.tar.gz New: ---- libsidplayfp-2.7.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libsidplayfp.spec ++++++ --- /var/tmp/diff_new_pack.a9L7EY/_old 2024-05-21 18:35:32.516409522 +0200 +++ /var/tmp/diff_new_pack.a9L7EY/_new 2024-05-21 18:35:32.532410104 +0200 @@ -19,7 +19,7 @@ %define soname 6 %define stilview_soname 0 Name: libsidplayfp -Version: 2.7.0 +Version: 2.7.1 Release: 0 Summary: A library to play Commodore 64 music License: GPL-2.0-or-later ++++++ libsidplayfp-2.7.0.tar.gz -> libsidplayfp-2.7.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/NEWS new/libsidplayfp-2.7.1/NEWS --- old/libsidplayfp-2.7.0/NEWS 2024-03-29 18:02:55.000000000 +0100 +++ new/libsidplayfp-2.7.1/NEWS 2024-05-19 10:16:35.000000000 +0200 @@ -1,3 +1,11 @@ +2.7.1 2024-05-19 +* Sync resid with upstream +* Make strong CWs the default (#127) +* Downtune the leakage parameter a bit (#126) +* Fix UBSan complaint abount uninitialized var 'is6581' + + + 2.7.0 2024-03-29 * residfp: refactor residfp filter (#109) * residfp: added ability to adjust the uCox parameter at runtime (#101) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/configure new/libsidplayfp-2.7.1/configure --- old/libsidplayfp-2.7.0/configure 2024-03-29 18:03:01.000000000 +0100 +++ new/libsidplayfp-2.7.1/configure 2024-05-19 10:16:43.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.71 for libsidplayfp 2.7.0. +# Generated by GNU Autoconf 2.71 for libsidplayfp 2.7.1. # # # Copyright (C) 1992-1996, 1998-2017, 2020-2021 Free Software Foundation, @@ -618,8 +618,8 @@ # Identity of this package. PACKAGE_NAME='libsidplayfp' PACKAGE_TARNAME='libsidplayfp' -PACKAGE_VERSION='2.7.0' -PACKAGE_STRING='libsidplayfp 2.7.0' +PACKAGE_VERSION='2.7.1' +PACKAGE_STRING='libsidplayfp 2.7.1' PACKAGE_BUGREPORT='' PACKAGE_URL='https://github.com/libsidplayfp/libsidplayfp/' @@ -1437,7 +1437,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures libsidplayfp 2.7.0 to adapt to many kinds of systems. +\`configure' configures libsidplayfp 2.7.1 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1508,7 +1508,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of libsidplayfp 2.7.0:";; + short | recursive ) echo "Configuration of libsidplayfp 2.7.1:";; esac cat <<\_ACEOF @@ -1654,7 +1654,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -libsidplayfp configure 2.7.0 +libsidplayfp configure 2.7.1 generated by GNU Autoconf 2.71 Copyright (C) 2021 Free Software Foundation, Inc. @@ -2413,7 +2413,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by libsidplayfp $as_me 2.7.0, which was +It was created by libsidplayfp $as_me 2.7.1, which was generated by GNU Autoconf 2.71. Invocation command line was $ $0$ac_configure_args_raw @@ -3903,7 +3903,7 @@ # Define the identity of the package. PACKAGE='libsidplayfp' - VERSION='2.7.0' + VERSION='2.7.1' printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h @@ -4009,7 +4009,7 @@ LIB_MAJOR=2 LIB_MINOR=7 -LIB_LEVEL=0 +LIB_LEVEL=1 @@ -19918,7 +19918,7 @@ # Increase the age value only if the changes made to the ABI are backward compatible. LIBSIDPLAYCUR=10 -LIBSIDPLAYREV=30 +LIBSIDPLAYREV=31 LIBSIDPLAYAGE=4 LIBSIDPLAYVERSION=$LIBSIDPLAYCUR:$LIBSIDPLAYREV:$LIBSIDPLAYAGE @@ -22431,7 +22431,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by libsidplayfp $as_me 2.7.0, which was +This file was extended by libsidplayfp $as_me 2.7.1, which was generated by GNU Autoconf 2.71. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -22500,7 +22500,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config='$ac_cs_config_escaped' ac_cs_version="\\ -libsidplayfp config.status 2.7.0 +libsidplayfp config.status 2.7.1 configured by $0, generated by GNU Autoconf 2.71, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/configure.ac new/libsidplayfp-2.7.1/configure.ac --- old/libsidplayfp-2.7.0/configure.ac 2024-03-29 18:02:55.000000000 +0100 +++ new/libsidplayfp-2.7.1/configure.ac 2024-05-19 10:16:35.000000000 +0200 @@ -1,6 +1,6 @@ m4_define([lib_major], [2]) m4_define([lib_minor], [7]) -m4_define([lib_level], [0]) +m4_define([lib_level], [1]) m4_define([lib_version], [lib_major.lib_minor.lib_level]) AC_PREREQ([2.62]) @@ -101,7 +101,7 @@ # Increase the age value only if the changes made to the ABI are backward compatible. LIBSIDPLAYCUR=10 -LIBSIDPLAYREV=30 +LIBSIDPLAYREV=31 LIBSIDPLAYAGE=4 LIBSIDPLAYVERSION=$LIBSIDPLAYCUR:$LIBSIDPLAYREV:$LIBSIDPLAYAGE diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/filter8580new.cc new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/filter8580new.cc --- old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/filter8580new.cc 2024-03-29 18:02:56.000000000 +0100 +++ new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/filter8580new.cc 2024-05-19 10:16:37.000000000 +0200 @@ -204,7 +204,7 @@ opamp_voltage_8580, sizeof(opamp_voltage_8580)/sizeof(*opamp_voltage_8580), // FIXME: Measure for the 8580. - 0.30, + 0.24, // FIXME: Measure for the 8580. 4.84, // Capacitor value. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/sid.cc new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/sid.cc --- old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/sid.cc 2024-03-29 18:02:56.000000000 +0100 +++ new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/sid.cc 2024-05-19 10:16:37.000000000 +0200 @@ -50,6 +50,11 @@ return (short)input; } +inline short amplify(int input, int scaleFactor) +{ + return clip((scaleFactor * input) / 2); +} + // ---------------------------------------------------------------------------- // Constructor. // ---------------------------------------------------------------------------- @@ -77,6 +82,8 @@ databus_ttl = 0; + scaleFactor = 3; + raw_debug_output = false; } @@ -110,6 +117,8 @@ */ databus_ttl = sid_model == MOS8580 ? 0xa2000 : 0x1d00; + scaleFactor = sid_model == MOS8580 ? 5 : 3; + for (int i = 0; i < 3; i++) { voice[i].set_chip_model(model); } @@ -872,7 +881,7 @@ } sample_offset = (next_sample_offset & FIXP_MASK) - (1 << (FIXP_SHIFT - 1)); - buf[s*interleave] = output(); + buf[s*interleave] = amplify(output(), scaleFactor); } return s; @@ -904,7 +913,7 @@ clock(); if (unlikely(i <= 2)) { sample_prev = sample_now; - sample_now = output(); + sample_now = clip(output()); } } @@ -915,8 +924,10 @@ sample_offset = next_sample_offset & FIXP_MASK; - buf[s*interleave] = - sample_prev + (sample_offset*(sample_now - sample_prev) >> FIXP_SHIFT); + buf[s*interleave] = amplify( + sample_prev + (sample_offset*(sample_now - sample_prev) >> FIXP_SHIFT), + scaleFactor + ); } return s; @@ -1016,7 +1027,7 @@ v >>= FIR_SHIFT; - buf[s*interleave] = clip(v); + buf[s*interleave] = amplify(v, scaleFactor); } return s; @@ -1040,7 +1051,7 @@ for (int i = 0; i < delta_t_sample; i++) { clock(); - sample[sample_index] = sample[sample_index + RINGSIZE] = output(); + sample[sample_index] = sample[sample_index + RINGSIZE] = clip(output()); ++sample_index &= RINGMASK; } @@ -1063,7 +1074,7 @@ v >>= FIR_SHIFT; - buf[s*interleave] = clip(v); + buf[s*interleave] = amplify(v, scaleFactor); } return s; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/sid.h new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/sid.h --- old/libsidplayfp-2.7.0/src/builders/resid-builder/resid/sid.h 2024-03-29 18:02:56.000000000 +0100 +++ new/libsidplayfp-2.7.1/src/builders/resid-builder/resid/sid.h 2024-05-19 10:16:37.000000000 +0200 @@ -130,6 +130,9 @@ double clock_frequency; + // Used to amplify the output by scaleFactor/2 to get an adequate playback volume + int scaleFactor; + enum { // Resampling constants. // The error in interpolated lookup is bounded by 1.234/L^2, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/src/builders/residfp-builder/residfp/Dac.cpp new/libsidplayfp-2.7.1/src/builders/residfp-builder/residfp/Dac.cpp --- old/libsidplayfp-2.7.0/src/builders/residfp-builder/residfp/Dac.cpp 2024-03-29 18:02:55.000000000 +0100 +++ new/libsidplayfp-2.7.1/src/builders/residfp-builder/residfp/Dac.cpp 2024-05-19 10:16:35.000000000 +0200 @@ -28,7 +28,7 @@ { Dac::Dac(unsigned int bits) : - leakage(0.01), + leakage(0.0075), dac(new double[bits]), dacLength(bits) {} diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsidplayfp-2.7.0/src/builders/residfp-builder/residfp/SID.cpp new/libsidplayfp-2.7.1/src/builders/residfp-builder/residfp/SID.cpp --- old/libsidplayfp-2.7.0/src/builders/residfp-builder/residfp/SID.cpp 2024-03-29 18:02:55.000000000 +0100 +++ new/libsidplayfp-2.7.1/src/builders/residfp-builder/residfp/SID.cpp 2024-05-19 10:16:36.000000000 +0200 @@ -141,7 +141,7 @@ resampler(nullptr), potX(new Potentiometer()), potY(new Potentiometer()), - cws(AVERAGE) + cws(STRONG) { voice[0].reset(new Voice()); voice[1].reset(new Voice()); @@ -149,8 +149,8 @@ muted[0] = muted[1] = muted[2] = false; - reset(); setChipModel(MOS8580); + reset(); } SID::~SID()
