Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package ark for openSUSE:Factory checked in at 2024-07-15 19:46:16 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ark (Old) and /work/SRC/openSUSE:Factory/.ark.new.17339 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ark" Mon Jul 15 19:46:16 2024 rev:172 rq:1187330 version:24.05.2 Changes: -------- --- /work/SRC/openSUSE:Factory/ark/ark.changes 2024-07-05 19:50:44.693416170 +0200 +++ /work/SRC/openSUSE:Factory/.ark.new.17339/ark.changes 2024-07-15 19:46:17.793107846 +0200 @@ -1,0 +2,6 @@ +Sat Jul 13 12:50:18 UTC 2024 - Fabian Vogt <fab...@ritter-vogt.de> + +- Add patch to fix tmp folder cleanup (kde#487229): + * 0001-cliinterface-adapt-to-behavior-change-in-QTemporaryD.patch + +------------------------------------------------------------------- New: ---- 0001-cliinterface-adapt-to-behavior-change-in-QTemporaryD.patch BETA DEBUG BEGIN: New:- Add patch to fix tmp folder cleanup (kde#487229): * 0001-cliinterface-adapt-to-behavior-change-in-QTemporaryD.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ark.spec ++++++ --- /var/tmp/diff_new_pack.4oOdma/_old 2024-07-15 19:46:18.549135547 +0200 +++ /var/tmp/diff_new_pack.4oOdma/_new 2024-07-15 19:46:18.549135547 +0200 @@ -31,6 +31,8 @@ Source1: https://download.kde.org/stable/release-service/%{version}/src/%{name}-%{version}.tar.xz.sig Source2: applications.keyring %endif +# PATCH-FIX-UPSTREAM +Patch1: 0001-cliinterface-adapt-to-behavior-change-in-QTemporaryD.patch BuildRequires: kf6-extra-cmake-modules >= %{kf6_version} BuildRequires: pkgconfig BuildRequires: cmake(KF6Config) >= %{kf6_version} ++++++ 0001-cliinterface-adapt-to-behavior-change-in-QTemporaryD.patch ++++++ >From b98ac44e9e42d23b20826eba69ddc767c27be15d Mon Sep 17 00:00:00 2001 From: Elvis Angelaccio <elvis.angelac...@kde.org> Date: Sat, 22 Jun 2024 17:54:07 +0200 Subject: [PATCH] cliinterface: adapt to behavior change in QTemporaryDir Qt 6.7 changed the behavior of QTemporaryDir (see commit 935562a77b in qtbase.git) and now QTemporaryDir::path() returns a relative path rather than an absolute one. We were relying on the old behavior which ensured that the extract temp dir would always auto-delete itself, regardless of the ark CWD. This is no longer working, because now when the temp dir gets deleted, its destructor tries to delete a relative path, but meanwhile ark has already changed the CWD and so that path does not exist. The fix is to create the QTemporaryDir with an absolute path (but still as hidden folder in the CWD), so we get back the old behavior (the returned QTemporaryDir::path() will again be absolute). BUG: 487229 --- kerfuffle/cliinterface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kerfuffle/cliinterface.cpp b/kerfuffle/cliinterface.cpp index c100d88f..8a317fe5 100644 --- a/kerfuffle/cliinterface.cpp +++ b/kerfuffle/cliinterface.cpp @@ -96,7 +96,7 @@ bool CliInterface::extractFiles(const QList<Archive::Entry *> &files, const QStr if (useTmpExtractDir) { // Create an hidden temp folder in the current directory. - m_extractTempDir.reset(new QTemporaryDir(QStringLiteral(".%1-").arg(QCoreApplication::applicationName()))); + m_extractTempDir.reset(new QTemporaryDir(QStringLiteral("%1/.%2-").arg(QDir::currentPath(), QCoreApplication::applicationName()))); qCDebug(ARK) << "Using temporary extraction dir:" << m_extractTempDir->path(); if (!m_extractTempDir->isValid()) { -- 2.45.2
