Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package kf6-kio for openSUSE:Factory checked
in at 2024-07-18 19:15:32
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kf6-kio (Old)
and /work/SRC/openSUSE:Factory/.kf6-kio.new.17339 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kf6-kio"
Thu Jul 18 19:15:32 2024 rev:7 rq:1188197 version:6.4.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/kf6-kio/kf6-kio.changes 2024-07-14
08:53:08.050225558 +0200
+++ /work/SRC/openSUSE:Factory/.kf6-kio.new.17339/kf6-kio.changes
2024-07-18 19:15:41.685573405 +0200
@@ -1,0 +2,7 @@
+Wed Jul 17 13:03:27 UTC 2024 - Fabian Vogt <fab...@ritter-vogt.de>
+
+- Add patch to fix issues with dropping files
+ (kde#490183, boo#1228053):
+ * 0001-Remove-parent-for-DropMenu.patch
+
+-------------------------------------------------------------------
New:
----
0001-Remove-parent-for-DropMenu.patch
BETA DEBUG BEGIN:
New: (kde#490183, boo#1228053):
* 0001-Remove-parent-for-DropMenu.patch
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kf6-kio.spec ++++++
--- /var/tmp/diff_new_pack.rxl6rf/_old 2024-07-18 19:15:42.857619831 +0200
+++ /var/tmp/diff_new_pack.rxl6rf/_new 2024-07-18 19:15:42.857619831 +0200
@@ -35,6 +35,8 @@
Source1: %{rname}-%{version}.tar.xz.sig
Source2: frameworks.keyring
%endif
+# PATCH-FIX-UPSTREAM
+Patch1: 0001-Remove-parent-for-DropMenu.patch
BuildRequires: doxygen
BuildRequires: fdupes
BuildRequires: kf6-extra-cmake-modules >= %{_kf6_bugfix_version}
++++++ 0001-Remove-parent-for-DropMenu.patch ++++++
>From ec27e22a8c48b526c8747669a0ebaa31bf3570c8 Mon Sep 17 00:00:00 2001
From: Vlad Zahorodnii <vlad.zahorod...@kde.org>
Date: Mon, 15 Jul 2024 09:45:20 +0300
Subject: [PATCH] Remove parent for DropMenu
QWidget::winId() will force creating window handles for all its ancestor
widgets unless the Qt::WA_DontCreateNativeAncestors flag is set.
For example, on wayland, this would result in creating sub-surfaces, and
depending on the client, it's likely that there are going to be issues with
painting.
On the other hand, since the DropJob takes care of setting the transient
parent for the DropMenu, the parent can be simply omitted.
BUG: 490183
(cherry picked from commit e0ea91afdf0dccef7e3afbf23a159bf5a8d6b249)
---
src/widgets/dropjob.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/widgets/dropjob.cpp b/src/widgets/dropjob.cpp
index e11e762bd..f4a23f568 100644
--- a/src/widgets/dropjob.cpp
+++ b/src/widgets/dropjob.cpp
@@ -520,8 +520,7 @@ void DropJobPrivate::slotDropActionDetermined(int error)
// There was an error, handle it
if (error == KIO::ERR_UNKNOWN) {
- auto *window = KJobWidgets::window(q);
- KIO::DropMenu *menu = new KIO::DropMenu(window);
+ KIO::DropMenu *menu = new KIO::DropMenu();
QObject::connect(menu, &QMenu::aboutToHide, menu,
&QObject::deleteLater);
// If the user clicks outside the menu, it will be destroyed without
emitting the triggered signal.
@@ -541,6 +540,7 @@ void DropJobPrivate::slotDropActionDetermined(int error)
menu->windowHandle()->setTransientParent(transientParent);
}
}
+ auto *window = KJobWidgets::window(q);
menu->popup(window ? window->mapToGlobal(m_relativePos) :
QCursor::pos());
}
m_menus.insert(menu);
--
2.45.2
