Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package b3sum for openSUSE:Factory checked in at 2024-07-22 17:15:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/b3sum (Old) and /work/SRC/openSUSE:Factory/.b3sum.new.17339 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "b3sum" Mon Jul 22 17:15:02 2024 rev:3 rq:1188516 version:1.5.3 Changes: -------- --- /work/SRC/openSUSE:Factory/b3sum/b3sum.changes 2024-07-15 19:47:07.666935318 +0200 +++ /work/SRC/openSUSE:Factory/.b3sum.new.17339/b3sum.changes 2024-07-22 17:15:17.882778585 +0200 @@ -1,0 +2,8 @@ +Thu Jul 18 01:35:13 UTC 2024 - Joshua Smith <smolsh...@opensuse.org> + +- Update to version 1.5.3: + * Revert the serialization change. It was intended to be + backwards compatible, but that didn't hold for + non-self-describing serialization formats like bincode. + +------------------------------------------------------------------- Old: ---- b3sum-1.5.2.obscpio New: ---- b3sum-1.5.3.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ b3sum.spec ++++++ --- /var/tmp/diff_new_pack.8dbQnO/_old 2024-07-22 17:15:19.410840031 +0200 +++ /var/tmp/diff_new_pack.8dbQnO/_new 2024-07-22 17:15:19.410840031 +0200 @@ -17,7 +17,7 @@ Name: b3sum -Version: 1.5.2 +Version: 1.5.3 Release: 0 Summary: A multithreaded rust implementation of BLAKE3 License: Apache-2.0 OR CC0-1.0 ++++++ b3sum-1.5.2.obscpio -> b3sum-1.5.3.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/Cargo.toml new/b3sum-1.5.3/Cargo.toml --- old/b3sum-1.5.2/Cargo.toml 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/Cargo.toml 2024-07-15 07:01:46.000000000 +0200 @@ -1,6 +1,6 @@ [package] name = "blake3" -version = "1.5.2" +version = "1.5.3" authors = ["Jack O'Connor <oconnor...@gmail.com>", "Samuel Neves"] description = "the BLAKE3 hash function" repository = "https://github.com/BLAKE3-team/BLAKE3" @@ -42,8 +42,6 @@ # Implement the zeroize::Zeroize trait for types in this crate. zeroize = ["dep:zeroize", "arrayvec/zeroize"] -serde = ["dep:serde", "dep:serde_bytes"] - # This crate implements traits from the RustCrypto project, exposed here as the # "traits-preview" feature. However, these traits aren't stable, and they're # expected to change in incompatible ways before they reach 1.0. For that @@ -105,7 +103,6 @@ memmap2 = { version = "0.9", optional = true } rayon-core = { version = "1.12.1", optional = true } serde = { version = "1.0", default-features = false, features = ["derive"], optional = true } -serde_bytes = { version = "0.11.15", optional = true } zeroize = { version = "1", default-features = false, features = ["zeroize_derive"], optional = true } [dev-dependencies] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/b3sum/Cargo.lock new/b3sum-1.5.3/b3sum/Cargo.lock --- old/b3sum-1.5.2/b3sum/Cargo.lock 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/b3sum/Cargo.lock 2024-07-15 07:01:46.000000000 +0200 @@ -71,7 +71,7 @@ [[package]] name = "b3sum" -version = "1.5.2" +version = "1.5.3" dependencies = [ "anyhow", "blake3", @@ -91,7 +91,7 @@ [[package]] name = "blake3" -version = "1.5.2" +version = "1.5.3" dependencies = [ "arrayref", "arrayvec", @@ -104,9 +104,9 @@ [[package]] name = "cc" -version = "1.1.1" +version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "907d8581360765417f8f2e0e7d602733bbed60156b4465b7617243689ef9b83d" +checksum = "324c74f2155653c90b04f25b2a47a8a631360cb908f92a772695f430c7e31052" [[package]] name = "cfg-if" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/b3sum/Cargo.toml new/b3sum-1.5.3/b3sum/Cargo.toml --- old/b3sum-1.5.2/b3sum/Cargo.toml 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/b3sum/Cargo.toml 2024-07-15 07:01:46.000000000 +0200 @@ -1,6 +1,6 @@ [package] name = "b3sum" -version = "1.5.2" +version = "1.5.3" authors = ["Jack O'Connor <oconnor...@gmail.com>"] description = "a command line implementation of the BLAKE3 hash function" repository = "https://github.com/BLAKE3-team/BLAKE3" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/c/CMakeLists.txt new/b3sum-1.5.3/c/CMakeLists.txt --- old/b3sum-1.5.2/c/CMakeLists.txt 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/c/CMakeLists.txt 2024-07-15 07:01:46.000000000 +0200 @@ -10,7 +10,7 @@ endif() project(libblake3 - VERSION 1.5.2 + VERSION 1.5.3 DESCRIPTION "BLAKE3 C implementation" LANGUAGES C ASM ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/c/blake3.h new/b3sum-1.5.3/c/blake3.h --- old/b3sum-1.5.2/c/blake3.h 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/c/blake3.h 2024-07-15 07:01:46.000000000 +0200 @@ -30,7 +30,7 @@ extern "C" { #endif -#define BLAKE3_VERSION_STRING "1.5.2" +#define BLAKE3_VERSION_STRING "1.5.3" #define BLAKE3_KEY_LEN 32 #define BLAKE3_OUT_LEN 32 #define BLAKE3_BLOCK_LEN 64 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/src/lib.rs new/b3sum-1.5.3/src/lib.rs --- old/b3sum-1.5.2/src/lib.rs 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/src/lib.rs 2024-07-15 07:01:46.000000000 +0200 @@ -219,12 +219,7 @@ #[cfg_attr(feature = "zeroize", derive(zeroize::Zeroize))] #[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))] #[derive(Clone, Copy, Hash)] -pub struct Hash( - #[rustfmt::skip] - // In formats like CBOR, bytestrings are more compact than lists of ints. - #[cfg_attr(feature = "serde", serde(with = "serde_bytes"))] - [u8; OUT_LEN], -); +pub struct Hash([u8; OUT_LEN]); impl Hash { /// The raw bytes of the `Hash`. Note that byte arrays don't provide diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/src/test.rs new/b3sum-1.5.3/src/test.rs --- old/b3sum-1.5.2/src/test.rs 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/src/test.rs 2024-07-15 07:01:46.000000000 +0200 @@ -826,25 +826,28 @@ assert_eq!( cbor, [ - 0x58, 0x20, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, - 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, - 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe + 0x98, 0x20, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, + 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, + 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, + 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, + 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, ] ); let hash_from_cbor: crate::Hash = ciborium::from_reader(&cbor[..]).unwrap(); assert_eq!(hash_from_cbor, hash); - // Before we used serde_bytes, the hash [254; 32] would serialize as an array instead of a - // byte string, like this. Make sure we can still deserialize this representation. - let old_cbor: &[u8] = &[ - 0x98, 0x20, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, - 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, - 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, - 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, - 0x18, 0xfe, 0x18, 0xfe, 0x18, 0xfe, + // Version 1.5.2 of this crate changed the default serialization format to a bytestring + // (instead of an array/list) to save bytes on the wire. That was a backwards compatibility + // mistake for non-self-describing formats, and it's been reverted. Since some small number of + // serialized bytestrings will probably exist forever in the wild, we shold test that we can + // still deserialize these from self-describing formats. + let bytestring_cbor: &[u8] = &[ + 0x58, 0x20, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, + 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, 0xfe, + 0xfe, 0xfe, 0xfe, 0xfe, ]; - let hash_from_old_cbor: crate::Hash = ciborium::from_reader(old_cbor).unwrap(); - assert_eq!(hash_from_old_cbor, hash); + let hash_from_bytestring_cbor: crate::Hash = ciborium::from_reader(bytestring_cbor).unwrap(); + assert_eq!(hash_from_bytestring_cbor, hash); } // `cargo +nightly miri test` currently works, but it takes forever, because some of our test diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/b3sum-1.5.2/tools/release.md new/b3sum-1.5.3/tools/release.md --- old/b3sum-1.5.2/tools/release.md 2024-07-12 18:50:13.000000000 +0200 +++ new/b3sum-1.5.3/tools/release.md 2024-07-15 07:01:46.000000000 +0200 @@ -12,5 +12,4 @@ - `git tag` the version bump commit with the new version number. - `git push --tags` - `cargo publish` in the root. -- `cargo publish --dry-run` in b3sum/ and make sure it fetches the just-published library version. - `cargo publish` in b3sum/. ++++++ b3sum.obsinfo ++++++ --- /var/tmp/diff_new_pack.8dbQnO/_old 2024-07-22 17:15:19.722852578 +0200 +++ /var/tmp/diff_new_pack.8dbQnO/_new 2024-07-22 17:15:19.726852739 +0200 @@ -1,5 +1,5 @@ name: b3sum -version: 1.5.2 -mtime: 1720803013 -commit: 27cbd6bdd5a8e9c3cf7f3e8f682056d297a8ba36 +version: 1.5.3 +mtime: 1721019706 +commit: acaeabeff3e051d5396e91732b1fd2f0b2641402 ++++++ vendor.tar.zst ++++++ /work/SRC/openSUSE:Factory/b3sum/vendor.tar.zst /work/SRC/openSUSE:Factory/.b3sum.new.17339/vendor.tar.zst differ: char 152040, line 636