Send commitlog mailing list submissions to
commitlog@lists.openmoko.org
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.openmoko.org/mailman/listinfo/commitlog
or, via email, send a message with subject or body 'help' to
commitlog-requ...@lists.openmoko.org
You can reach the person managing the list at
commitlog-ow...@lists.openmoko.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of commitlog digest..."
Today's Topics:
1. r5915 - trunk/eda/fped (wer...@docs.openmoko.org)
2. r5916 - trunk/src/host/dfu-util/src (ste...@docs.openmoko.org)
3. r5917 - trunk/src/host/dfu-util/src (alpha...@docs.openmoko.org)
--- Begin Message ---
Author: werner
Date: 2010-04-18 18:43:41 +0200 (Sun, 18 Apr 2010)
New Revision: 5915
Modified:
trunk/eda/fped/gui_status.c
Log:
When editing, fped would sometimes not respond to [Enter] if the value had not
changed. This was particularly noticeable when editing variable names.
- gui_status.c (activate): reset the selection (along with all open edits) also
when nothing has changed
Modified: trunk/eda/fped/gui_status.c
===================================================================
--- trunk/eda/fped/gui_status.c 2010-04-13 12:48:04 UTC (rev 5914)
+++ trunk/eda/fped/gui_status.c 2010-04-18 16:43:41 UTC (rev 5915)
@@ -807,8 +807,10 @@
if (status == es_good)
unchanged = 0;
}
- if (unchanged)
+ if (unchanged) {
+ inst_deselect();
return TRUE;
+ }
for (edit = open_edits; edit;
edit = gtk_object_get_data(GTK_OBJECT(edit), "edit-next"))
if (get_status(edit) == es_good) {
--- End Message ---
--- Begin Message ---
Author: stefan
Date: 2010-04-18 21:06:33 +0200 (Sun, 18 Apr 2010)
New Revision: 5916
Modified:
trunk/src/host/dfu-util/src/main.c
Log:
src/main.c: Fix last commit for good.
Thanks to Werner Almesberger for spotting this. Long standing problem. Due to
the bitwise AND instead of an logical AND check we always skipped this check and
dropped back to 0 which is loading into RAM on OM devices.
Modified: trunk/src/host/dfu-util/src/main.c
===================================================================
--- trunk/src/host/dfu-util/src/main.c 2010-04-18 16:43:41 UTC (rev 5915)
+++ trunk/src/host/dfu-util/src/main.c 2010-04-18 19:06:33 UTC (rev 5916)
@@ -707,7 +707,7 @@
"DFU IF\n");
exit(1);
}
- } else if (num_ifs > 1 && (!dif->flags) & (DFU_IFF_IFACE|DFU_IFF_ALT)) {
+ } else if (num_ifs > 1 && !dif->flags && (DFU_IFF_IFACE|DFU_IFF_ALT)) {
fprintf(stderr, "We have %u DFU Interfaces/Altsettings, "
"you have to specify one via --intf / --alt options\n",
num_ifs);
--- End Message ---
--- Begin Message ---
Author: alphaone
Date: 2010-04-19 00:01:19 +0200 (Mon, 19 Apr 2010)
New Revision: 5917
Modified:
trunk/src/host/dfu-util/src/main.c
Log:
Correctly fix problem introduced by revision 5910
!dif->flags & (DFU_IFF_IFACE|DFU_IFF_ALT) is supposed to check if
neither the flags DFU_IFF_IFACE or DFU_IFF_ALT are set. The problem is
that ! has higher precedence than &. The parentheses (which are always
good if they improve readability) solve the problem.
Modified: trunk/src/host/dfu-util/src/main.c
===================================================================
--- trunk/src/host/dfu-util/src/main.c 2010-04-18 19:06:33 UTC (rev 5916)
+++ trunk/src/host/dfu-util/src/main.c 2010-04-18 22:01:19 UTC (rev 5917)
@@ -707,7 +707,7 @@
"DFU IF\n");
exit(1);
}
- } else if (num_ifs > 1 && !dif->flags && (DFU_IFF_IFACE|DFU_IFF_ALT)) {
+ } else if (num_ifs > 1 && !(dif->flags & (DFU_IFF_IFACE|DFU_IFF_ALT))) {
fprintf(stderr, "We have %u DFU Interfaces/Altsettings, "
"you have to specify one via --intf / --alt options\n",
num_ifs);
--- End Message ---
_______________________________________________
commitlog mailing list
commitlog@lists.openmoko.org
http://lists.openmoko.org/mailman/listinfo/commitlog
