Repository: accumulo Updated Branches: refs/heads/master 3086472f4 -> 36a97ac01
ACCUMULO-2697 Look for serious findbug issues in the build Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/e4b08b17 Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/e4b08b17 Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/e4b08b17 Branch: refs/heads/master Commit: e4b08b17ff0f42db6ba64f79cd277a918fe6fc23 Parents: b383cc5 Author: Christopher Tubbs <ctubb...@apache.org> Authored: Mon Apr 21 12:18:59 2014 -0400 Committer: Christopher Tubbs <ctubb...@apache.org> Committed: Mon Apr 21 15:16:26 2014 -0400 ---------------------------------------------------------------------- core/pom.xml | 7 +++++ core/src/main/findbugs/exclude-filter.xml | 36 +++++++++++++++++++++++++ pom.xml | 24 +++++++++++++++++ proxy/pom.xml | 13 +++++++++ proxy/src/main/findbugs/exclude-filter.xml | 21 +++++++++++++++ trace/pom.xml | 13 +++++++++ trace/src/main/findbugs/exclude-filter.xml | 21 +++++++++++++++ 7 files changed, 135 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/core/pom.xml ---------------------------------------------------------------------- diff --git a/core/pom.xml b/core/pom.xml index dbb924d..2509435 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -167,6 +167,13 @@ </excludes> </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <configuration> + <excludeFilterFile>src/main/findbugs/exclude-filter.xml</excludeFilterFile> + </configuration> + </plugin> </plugins> </pluginManagement> <plugins> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/core/src/main/findbugs/exclude-filter.xml ---------------------------------------------------------------------- diff --git a/core/src/main/findbugs/exclude-filter.xml b/core/src/main/findbugs/exclude-filter.xml new file mode 100644 index 0000000..88b7922 --- /dev/null +++ b/core/src/main/findbugs/exclude-filter.xml @@ -0,0 +1,36 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <Class name="~org\.apache\.accumulo\.core\.client\.impl\.thrift\..*" /> + </Match> + <Match> + <Class name="~org\.apache\.accumulo\.core\.data\.thrift\..*" /> + </Match> + <Match> + <Class name="~org\.apache\.accumulo\.core\.gc\.thrift\..*" /> + </Match> + <Match> + <Class name="~org\.apache\.accumulo\.core\.master\.thrift\..*" /> + </Match> + <Match> + <Class name="~org\.apache\.accumulo\.core\.security\.thrift\..*" /> + </Match> + <Match> + <Class name="~org\.apache\.accumulo\.core\.tabletserver\.thrift\..*" /> + </Match> +</FindBugsFilter> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index f109643..d321c55 100644 --- a/pom.xml +++ b/pom.xml @@ -452,6 +452,18 @@ <pluginManagement> <plugins> <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>2.5.3</version> + <configuration> + <xmlOutput>true</xmlOutput> + <effort>Max</effort> + <failOnError>true</failOnError> + <includeTests>true</includeTests> + <maxRank>1</maxRank> + </configuration> + </plugin> + <plugin> <groupId>com.google.code.sortpom</groupId> <artifactId>maven-sortpom-plugin</artifactId> <version>2.3.0</version> @@ -815,6 +827,18 @@ </executions> </plugin> <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <executions> + <execution> + <id>run-findbugs</id> + <goals> + <goal>check</goal> + </goals> + </execution> + </executions> + </plugin> + <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-scm-publish-plugin</artifactId> <executions> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/proxy/pom.xml ---------------------------------------------------------------------- diff --git a/proxy/pom.xml b/proxy/pom.xml index a994e53..d1e0ebb 100644 --- a/proxy/pom.xml +++ b/proxy/pom.xml @@ -87,6 +87,19 @@ <scope>test</scope> </dependency> </dependencies> + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <configuration> + <excludeFilterFile>src/main/findbugs/exclude-filter.xml</excludeFilterFile> + </configuration> + </plugin> + </plugins> + </pluginManagement> + </build> <profiles> <profile> <id>thrift</id> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/proxy/src/main/findbugs/exclude-filter.xml ---------------------------------------------------------------------- diff --git a/proxy/src/main/findbugs/exclude-filter.xml b/proxy/src/main/findbugs/exclude-filter.xml new file mode 100644 index 0000000..97cf1ef --- /dev/null +++ b/proxy/src/main/findbugs/exclude-filter.xml @@ -0,0 +1,21 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <Class name="~org\.apache\.accumulo\.proxy\.thrift\..*" /> + </Match> +</FindBugsFilter> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/trace/pom.xml ---------------------------------------------------------------------- diff --git a/trace/pom.xml b/trace/pom.xml index 8cd6969..0c34dfa 100644 --- a/trace/pom.xml +++ b/trace/pom.xml @@ -53,6 +53,19 @@ <scope>test</scope> </dependency> </dependencies> + <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <configuration> + <excludeFilterFile>src/main/findbugs/exclude-filter.xml</excludeFilterFile> + </configuration> + </plugin> + </plugins> + </pluginManagement> + </build> <profiles> <profile> <id>thrift</id> http://git-wip-us.apache.org/repos/asf/accumulo/blob/e4b08b17/trace/src/main/findbugs/exclude-filter.xml ---------------------------------------------------------------------- diff --git a/trace/src/main/findbugs/exclude-filter.xml b/trace/src/main/findbugs/exclude-filter.xml new file mode 100644 index 0000000..408a32c --- /dev/null +++ b/trace/src/main/findbugs/exclude-filter.xml @@ -0,0 +1,21 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <Class name="~org\.apache\.accumulo\.trace\.thrift\..*" /> + </Match> +</FindBugsFilter>
