This is an automated email from the ASF dual-hosted git repository. jmark99 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/main by this push: new e20aae4 Add some missing @Override annotations. (#2444) e20aae4 is described below commit e20aae49c6ae1e68de443b17fb9f2979dfb04744 Author: Mark Owens <jmar...@apache.org> AuthorDate: Tue Feb 1 09:01:43 2022 -0500 Add some missing @Override annotations. (#2444) Added several @Override annotations to six Accumulo classes. --- .../org/apache/accumulo/core/clientImpl/CloneConfigurationImpl.java | 4 ++++ .../main/java/org/apache/accumulo/core/constraints/Constraint.java | 3 +++ .../apache/accumulo/hadoopImpl/mapreduce/lib/MapReduceClientOpts.java | 1 + .../org/apache/accumulo/server/conf/codec/VersionedPropGzipCodec.java | 1 + .../org/apache/accumulo/server/manager/state/MetaDataStateStore.java | 1 + .../java/org/apache/accumulo/tserver/compactions/PrintableTable.java | 1 + 6 files changed, 11 insertions(+) diff --git a/core/src/main/java/org/apache/accumulo/core/clientImpl/CloneConfigurationImpl.java b/core/src/main/java/org/apache/accumulo/core/clientImpl/CloneConfigurationImpl.java index 1e45d01..1264fc4 100644 --- a/core/src/main/java/org/apache/accumulo/core/clientImpl/CloneConfigurationImpl.java +++ b/core/src/main/java/org/apache/accumulo/core/clientImpl/CloneConfigurationImpl.java @@ -53,23 +53,27 @@ public class CloneConfigurationImpl implements CloneConfiguration, CloneConfigur public CloneConfigurationImpl() {} + @Override public boolean isFlush() { Preconditions.checkState(built); return flush; } + @Override public Map<String,String> getPropertiesToSet() { Preconditions.checkState(built); return (propertiesToSet == null ? Collections.<String,String>emptyMap() : Collections.unmodifiableMap(propertiesToSet)); } + @Override public Set<String> getPropertiesToExclude() { Preconditions.checkState(built); return (propertiesToExclude == null ? Collections.<String>emptySet() : Collections.unmodifiableSet(propertiesToExclude)); } + @Override public boolean isKeepOffline() { Preconditions.checkState(built); return keepOffline; diff --git a/core/src/main/java/org/apache/accumulo/core/constraints/Constraint.java b/core/src/main/java/org/apache/accumulo/core/constraints/Constraint.java index b24d613..bad1268 100644 --- a/core/src/main/java/org/apache/accumulo/core/constraints/Constraint.java +++ b/core/src/main/java/org/apache/accumulo/core/constraints/Constraint.java @@ -52,6 +52,7 @@ public interface Constraint extends org.apache.accumulo.core.data.constraints.Co * * @return user */ + @Override String getUser(); /** @@ -59,6 +60,7 @@ public interface Constraint extends org.apache.accumulo.core.data.constraints.Co * * @return authorizations */ + @Override AuthorizationContainer getAuthorizationsContainer(); } @@ -69,6 +71,7 @@ public interface Constraint extends org.apache.accumulo.core.data.constraints.Co * numeric violation code * @return matching violation description */ + @Override String getViolationDescription(short violationCode); /** diff --git a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/lib/MapReduceClientOpts.java b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/lib/MapReduceClientOpts.java index d05244b..28099f2 100644 --- a/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/lib/MapReduceClientOpts.java +++ b/hadoop-mapreduce/src/main/java/org/apache/accumulo/hadoopImpl/mapreduce/lib/MapReduceClientOpts.java @@ -42,6 +42,7 @@ public class MapReduceClientOpts extends ClientOpts { private static final Logger log = LoggerFactory.getLogger(MapReduceClientOpts.class); + @Override public Properties getClientProps() { Properties props = super.getClientProps(); // For MapReduce, Kerberos credentials don't make it to the Mappers and Reducers, diff --git a/server/base/src/main/java/org/apache/accumulo/server/conf/codec/VersionedPropGzipCodec.java b/server/base/src/main/java/org/apache/accumulo/server/conf/codec/VersionedPropGzipCodec.java index 139469d..2a2ef0c 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/conf/codec/VersionedPropGzipCodec.java +++ b/server/base/src/main/java/org/apache/accumulo/server/conf/codec/VersionedPropGzipCodec.java @@ -71,6 +71,7 @@ public class VersionedPropGzipCodec extends VersionedPropCodec { return encodingOpts.getEncodingVersion() == EncodingOptions.EncodingVersion_1_0; } + @Override Map<String,String> decodePayload(final InputStream inStream, final EncodingOptions encodingOpts) throws IOException { // read the property map keys, values diff --git a/server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java b/server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java index e9dd77a..bcab51e 100644 --- a/server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java +++ b/server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java @@ -56,6 +56,7 @@ class MetaDataStateStore implements TabletStateStore { return new MetaDataTableScanner(context, TabletsSection.getRange(), state, targetTableName); } + @Override public void setLocations(Collection<Assignment> assignments) throws DistributedStoreException { try (var tabletsMutator = ample.mutateTablets()) { for (Assignment assignment : assignments) { diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/PrintableTable.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/PrintableTable.java index 19de547..4b282f0 100644 --- a/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/PrintableTable.java +++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/PrintableTable.java @@ -31,6 +31,7 @@ public class PrintableTable { this.data = data; } + @Override public String toString() { int widestRow = Arrays.asList(rows).stream().mapToInt(String::length).max().getAsInt();