Remove unnecessary @SuppressWarnings("unchecked")
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/7bf3923c Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/7bf3923c Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/7bf3923c Branch: refs/heads/master Commit: 7bf3923ceee9b27e800062cff1dbd6496d48431d Parents: 96e99e4 Author: Ville Skyttä <ville.sky...@iki.fi> Authored: Sun Dec 6 02:11:32 2015 +0200 Committer: Ville Skyttä <ville.sky...@iki.fi> Committed: Mon Dec 7 22:55:05 2015 +0200 ---------------------------------------------------------------------- .../src/main/java/org/apache/activemq/artemis/cli/Artemis.java | 1 - .../apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java | 1 - .../activemq/artemis/jms/server/impl/JMSServerManagerImpl.java | 1 - .../artemis/core/management/impl/ActiveMQServerControlImpl.java | 1 - .../activemq/artemis/core/security/jaas/StubX509Certificate.java | 4 ++-- .../src/test/java/org/apache/activemq/JmsQueueBrowserTest.java | 1 - .../src/test/java/org/apache/activemq/bugs/AMQ2171Test.java | 1 - .../org/apache/activemq/console/command/PurgeCommandTest.java | 2 -- .../activemq/jndi/ActiveMQWASInitialContextFactoryTest.java | 1 - .../activemq/network/BrokerNetworkWithStuckMessagesTest.java | 2 +- .../activemq/artemis/jms/tests/message/MessageBodyTest.java | 1 - .../artemis/jms/tests/message/MessageHeaderTestBase.java | 1 - 12 files changed, 3 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java ---------------------------------------------------------------------- diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java index 2faccf9..681a745 100644 --- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java +++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java @@ -42,7 +42,6 @@ import org.apache.activemq.artemis.cli.commands.tools.XmlDataImporter; public class Artemis { - @SuppressWarnings("unchecked") public static void main(String... args) throws Exception { execute(null, null, args); } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java ---------------------------------------------------------------------- diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java index 5cbde39..3a8e519 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/bridge/impl/JMSBridgeImpl.java @@ -1554,7 +1554,6 @@ public final class JMSBridgeImpl implements JMSBridge { * don't lose them!! */ private static void copyProperties(final Message msg) throws JMSException { - @SuppressWarnings("unchecked") Enumeration<String> en = msg.getPropertyNames(); Map<String, Object> oldProps = null; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java ---------------------------------------------------------------------- diff --git a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java index 94d7487..35f584b 100644 --- a/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java +++ b/artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/impl/JMSServerManagerImpl.java @@ -1374,7 +1374,6 @@ public class JMSServerManagerImpl implements JMSServerManager, ActivateCallback JSONObject msgJson = msgs.getJSONObject(i); JSONObject props = msgJson.getJSONObject(TransactionDetail.KEY_MSG_PROPERTIES); StringBuilder propstr = new StringBuilder(); - @SuppressWarnings("unchecked") Iterator<String> propkeys = props.keys(); while (propkeys.hasNext()) { String key = propkeys.next(); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java ---------------------------------------------------------------------- diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java b/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java index 5382621..9ee0bb2 100644 --- a/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java +++ b/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java @@ -933,7 +933,6 @@ public class ActiveMQServerControlImpl extends AbstractControl implements Active JSONObject msgJson = msgs.getJSONObject(i); JSONObject props = msgJson.getJSONObject(TransactionDetail.KEY_MSG_PROPERTIES); StringBuilder propstr = new StringBuilder(); - @SuppressWarnings("unchecked") Iterator<String> propkeys = props.keys(); while (propkeys.hasNext()) { String key = propkeys.next(); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/StubX509Certificate.java ---------------------------------------------------------------------- diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/StubX509Certificate.java b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/StubX509Certificate.java index d59a12a..9ccaae0 100644 --- a/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/StubX509Certificate.java +++ b/artemis-server/src/test/java/org/apache/activemq/artemis/core/security/jaas/StubX509Certificate.java @@ -136,12 +136,12 @@ public class StubX509Certificate extends X509Certificate { return false; } - @SuppressWarnings({"unchecked", "rawtypes"}) + @SuppressWarnings("rawtypes") public Set getCriticalExtensionOIDs() { return null; } - @SuppressWarnings({"unchecked", "rawtypes"}) + @SuppressWarnings("rawtypes") public Set getNonCriticalExtensionOIDs() { return null; } http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java ---------------------------------------------------------------------- diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java index b458223..fdba2e3 100644 --- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java +++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java @@ -360,7 +360,6 @@ public class JmsQueueBrowserTest extends JmsTestSupport { } QueueBrowser browser = session2.createBrowser(destinationPrefetch1); - @SuppressWarnings("unchecked") Enumeration<Message> browserView = browser.getEnumeration(); List<Message> messages = new ArrayList<>(); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ2171Test.java ---------------------------------------------------------------------- diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ2171Test.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ2171Test.java index e6026fd..ea794ff 100644 --- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ2171Test.java +++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ2171Test.java @@ -88,7 +88,6 @@ public class AMQ2171Test implements Thread.UncaughtExceptionHandler { connection.start(); Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE); - @SuppressWarnings("unchecked") Enumeration<Message> unread = session.createBrowser(destination).getEnumeration(); int count = 0; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java ---------------------------------------------------------------------- diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java index cc30cb0..b238452 100644 --- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java +++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/console/command/PurgeCommandTest.java @@ -147,7 +147,6 @@ public class PurgeCommandTest extends TestCase { return ManagementFactory.getPlatformMBeanServer(); } - @SuppressWarnings("unchecked") public void purgeAllMessages() throws IOException, Exception { List<ObjectInstance> queueList = JmxMBeansUtil.queryMBeans(createJmxConnection(), "type=Broker,brokerName=localbroker,destinationType=Queue,destinationName=*"); for (ObjectInstance oi : queueList) { @@ -199,7 +198,6 @@ public class PurgeCommandTest extends TestCase { * * @throws Exception */ - @SuppressWarnings("unchecked") public void testQueueViewMbean() throws Exception { try { http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/jndi/ActiveMQWASInitialContextFactoryTest.java ---------------------------------------------------------------------- diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/jndi/ActiveMQWASInitialContextFactoryTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/jndi/ActiveMQWASInitialContextFactoryTest.java index 0a4fb47..a89c94c 100644 --- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/jndi/ActiveMQWASInitialContextFactoryTest.java +++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/jndi/ActiveMQWASInitialContextFactoryTest.java @@ -22,7 +22,6 @@ import javax.naming.Context; public class ActiveMQWASInitialContextFactoryTest extends JNDITestSupport { - @SuppressWarnings("unchecked") public void testTransformEnvironment() { Hashtable<Object, Object> originalEnvironment = new Hashtable<>(); originalEnvironment.put("java.naming.connectionFactoryNames", "ConnectionFactory"); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/network/BrokerNetworkWithStuckMessagesTest.java ---------------------------------------------------------------------- diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/network/BrokerNetworkWithStuckMessagesTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/network/BrokerNetworkWithStuckMessagesTest.java index fe6f31c..c483715 100644 --- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/network/BrokerNetworkWithStuckMessagesTest.java +++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/network/BrokerNetworkWithStuckMessagesTest.java @@ -477,7 +477,7 @@ public class BrokerNetworkWithStuckMessagesTest { return connection; } - @SuppressWarnings({"unchecked", "unused"}) + @SuppressWarnings("unused") private Object[] browseQueueWithJms(BrokerService broker) throws Exception { Object[] messages = null; Connection connection = null; http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageBodyTest.java ---------------------------------------------------------------------- diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageBodyTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageBodyTest.java index 5bafb64..4614a6e 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageBodyTest.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageBodyTest.java @@ -571,7 +571,6 @@ public class MessageBodyTest extends MessageBodyTestCase { ProxyAssertSupport.assertFalse(m2.itemExists("sausages")); HashSet<String> itemNames = new HashSet<>(); - @SuppressWarnings("unchecked") Enumeration<String> en = m2.getMapNames(); while (en.hasMoreElements()) { String propName = en.nextElement(); http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/7bf3923c/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTestBase.java ---------------------------------------------------------------------- diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTestBase.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTestBase.java index f57f9b9..219c4c9 100644 --- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTestBase.java +++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTestBase.java @@ -290,7 +290,6 @@ public abstract class MessageHeaderTestBase extends ActiveMQServerTestCase { } } - @SuppressWarnings("unchecked") public static void ensureEquivalent(final MapMessage m1, final ActiveMQMapMessage m2) throws JMSException { MessageHeaderTestBase.ensureEquivalent((Message) m1, m2);