NO-JIRA fix flaky tests 
QueueControlTest#testChangeMessagePriority{,WithInvalidValue}

The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/c6521e07
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/c6521e07
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/c6521e07

Branch: refs/heads/master
Commit: c6521e0700006de1a00b614768168a0f96c5e28b
Parents: 23a30b6
Author: Jiri Danek <jda...@redhat.com>
Authored: Tue Aug 7 20:02:41 2018 +0200
Committer: Clebert Suconic <clebertsuco...@apache.org>
Committed: Wed Aug 8 11:31:23 2018 -0400

----------------------------------------------------------------------
 .../artemis/tests/integration/management/QueueControlTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/c6521e07/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
----------------------------------------------------------------------
diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
index 46d360e..9f4a93c 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
@@ -1926,7 +1926,7 @@ public class QueueControlTest extends ManagementTestBase {
       producer.send(message);
 
       QueueControl queueControl = createManagementControl(address, queue);
-      Assert.assertEquals(1, getMessageCount(queueControl));
+      Wait.assertEquals(1, () -> getMessageCount(queueControl));
 
       // the message IDs are set on the server
       Map<String, Object>[] messages = queueControl.listMessages(null);
@@ -1959,7 +1959,7 @@ public class QueueControlTest extends ManagementTestBase {
       producer.send(message);
 
       QueueControl queueControl = createManagementControl(address, queue);
-      Assert.assertEquals(1, getMessageCount(queueControl));
+      Wait.assertEquals(1, () -> getMessageCount(queueControl));
 
       // the message IDs are set on the server
       Map<String, Object>[] messages = queueControl.listMessages(null);

Reply via email to