This is an automated email from the ASF dual-hosted git repository. robbie pushed a commit to branch new-logging in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
commit 0b7daa77e1e676e9c3280a5c3a6b67f8381b3f36 Author: Robbie Gemmell <[email protected]> AuthorDate: Tue May 24 17:23:23 2022 +0100 add TODO about potentially expensive preparation of probably-not-logged details --- .../apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java index 8372741b8f..f8baad2032 100644 --- a/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java +++ b/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java @@ -330,7 +330,7 @@ public final class XmlDataImporter extends ActionAbstract { logMessage.delete(logMessage.length() - 2, logMessage.length()); // take off the trailing comma if (logger.isDebugEnabled()) { - logger.debug(logMessage.toString()); + logger.debug(logMessage.toString()); //TODO: this potentially expensive logMessage StringBuilder is still prepared even if debug isnt enabled } message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
