This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new aade3b35f6 NO-JIRA Fixing intermittent test failures
aade3b35f6 is described below

commit aade3b35f6baa62e94cbe4353ef0bebbc2dde9f7
Author: Clebert Suconic <[email protected]>
AuthorDate: Mon Jun 3 14:31:13 2024 -0400

    NO-JIRA Fixing intermittent test failures
---
 .../tests/integration/client/LargeMessageTest.java  | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
index d70dd91e25..5eca653556 100644
--- 
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
+++ 
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/LargeMessageTest.java
@@ -67,7 +67,6 @@ import org.apache.activemq.artemis.core.config.Configuration;
 import org.apache.activemq.artemis.core.config.DivertConfiguration;
 import org.apache.activemq.artemis.core.config.StoreConfiguration;
 import org.apache.activemq.artemis.core.paging.PagingStore;
-import 
org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager;
 import 
org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl;
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
 import org.apache.activemq.artemis.core.server.LargeServerMessage;
@@ -2609,7 +2608,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
 
       server.start();
 
-      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl((JournalStorageManager) server.getStorageManager());
+      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl(server.getStorageManager());
 
       fileMessage.setMessageID(1005);
 
@@ -2625,7 +2624,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
       // The server would be doing this
       fileMessage.putLongProperty(Message.HDR_LARGE_BODY_SIZE, 
largeMessageSize);
 
-      fileMessage.releaseResources(false, false);
+      fileMessage.releaseResources(true, false);
 
       assertEquals(largeMessageSize, fileMessage.getBodyBufferSize());
    }
@@ -2641,7 +2640,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
 
       ClientSession session = sf.createSession(false, false);
 
-      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl((JournalStorageManager) server.getStorageManager());
+      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl(server.getStorageManager());
 
       fileMessage.setMessageID(1005);
 
@@ -2652,7 +2651,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
       // The server would be doing this
       fileMessage.putLongProperty(Message.HDR_LARGE_BODY_SIZE, 
largeMessageSize);
 
-      fileMessage.releaseResources(false, false);
+      fileMessage.releaseResources(true, false);
 
       session.createQueue(new QueueConfiguration(ADDRESS));
 
@@ -2701,14 +2700,10 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
          fileMessage.addBytes(new byte[]{ActiveMQTestBase.getSamplebyte(i)});
       }
 
-      // we need to call sync, especially for JDBC Storage.
-      // we need to make sure the database has all the packets before a send 
can be called
-      fileMessage.getAppendFile().sync();
-
       // The server would be doing this
       fileMessage.putLongProperty(Message.HDR_LARGE_BODY_SIZE, 
largeMessageSize);
 
-      fileMessage.releaseResources(false, false);
+      fileMessage.releaseResources(true, false);
 
       session.createQueue(new QueueConfiguration(ADDRESS));
 
@@ -2730,7 +2725,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
 
       assertEquals(largeMessageSize, producer.getMessagesSentSize());
 
-      fileMessage = new LargeServerMessageImpl((JournalStorageManager) 
server.getStorageManager());
+      fileMessage = new LargeServerMessageImpl(server.getStorageManager());
 
       fileMessage.setMessageID(1006);
 
@@ -2884,7 +2879,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
 
       ClientSession session = sf.createSession(false, false);
 
-      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl((JournalStorageManager) server.getStorageManager());
+      LargeServerMessageImpl fileMessage = new 
LargeServerMessageImpl(server.getStorageManager());
 
       fileMessage.setMessageID(1005);
 
@@ -2892,7 +2887,7 @@ public class LargeMessageTest extends 
LargeMessageTestBase {
          fileMessage.addBytes(new byte[]{ActiveMQTestBase.getSamplebyte(i)});
       }
 
-      fileMessage.releaseResources(false, false);
+      fileMessage.releaseResources(true, false);
 
       session.createQueue(new QueueConfiguration(ADDRESS));
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to