This is an automated email from the ASF dual-hosted git repository.
robbie pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 9620f8279e ARTEMIS-5173 Fix test failure due to NPE after Queue lookup
9620f8279e is described below
commit 9620f8279eb06a957bfca324b3093d7d171e43c3
Author: Timothy Bish <[email protected]>
AuthorDate: Wed Dec 4 09:22:53 2024 -0500
ARTEMIS-5173 Fix test failure due to NPE after Queue lookup
The lookup of the just created queues can return null on a very slow
machine causing the test to fail, add Waits with queue queries to allow
the Queues to get created on both brokers.
---
.../amqp/connect/AMQPMirrorOneSideDisconnectedTest.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPMirrorOneSideDisconnectedTest.java
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPMirrorOneSideDisconnectedTest.java
index 82e4fe070f..581483959f 100644
---
a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPMirrorOneSideDisconnectedTest.java
+++
b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPMirrorOneSideDisconnectedTest.java
@@ -27,6 +27,7 @@ import java.util.HashMap;
import org.apache.activemq.artemis.api.core.QueueConfiguration;
import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.api.core.SimpleString;
import org.apache.activemq.artemis.api.core.TransportConfiguration;
import org.apache.activemq.artemis.core.config.DivertConfiguration;
import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPBrokerConnectConfiguration;
@@ -113,12 +114,16 @@ public class AMQPMirrorOneSideDisconnectedTest extends
ActiveMQTestBase {
} catch (Exception ignored) {
}
+ Wait.assertTrue(() ->
serverA.queueQuery(SimpleString.of(queueName)).isExists(), 5000, 100);
+ Wait.assertTrue(() ->
serverB.queueQuery(SimpleString.of(queueName)).isExists(), 5000, 100);
+ Wait.assertTrue(() ->
serverA.queueQuery(SimpleString.of(divertedQueue)).isExists(), 5000, 100);
+ Wait.assertTrue(() ->
serverB.queueQuery(SimpleString.of(divertedQueue)).isExists(), 5000, 100);
+
Queue divertedQueueA = serverA.locateQueue(divertedQueue);
Queue divertedQueueB = serverB.locateQueue(divertedQueue);
Queue queueA = serverA.locateQueue(queueName);
Queue queueB = serverB.locateQueue(queueName);
-
long nmessages = 10;
ConnectionFactory factoryA =
CFUtil.createConnectionFactory(randomProtocol(), "tcp://localhost:5671");
@@ -136,7 +141,6 @@ public class AMQPMirrorOneSideDisconnectedTest extends
ActiveMQTestBase {
Wait.assertEquals(nmessages, queueA::getMessageCount, 5000, 100);
Wait.assertEquals(nmessages, queueB::getMessageCount, 5000, 100);
-
Queue serverAMirrorSNF =
serverA.locateQueue("$ACTIVEMQ_ARTEMIS_MIRROR_A_to_B");
Wait.assertEquals(0L, serverAMirrorSNF::getMessageCount, 5000, 100);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
