This is an automated email from the ASF dual-hosted git repository.
jbertram pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 98723dd2dc ARTEMIS-5582: Update to errorprone 2.40.0
98723dd2dc is described below
commit 98723dd2dcf8b8656d80149ce550ddbcfb29245e
Author: Robbie Gemmell <[email protected]>
AuthorDate: Mon Jul 21 16:52:01 2025 +0100
ARTEMIS-5582: Update to errorprone 2.40.0
- Builds, but doesnt run, the optional activemq5-unit-tests module in
check builds > JDK17 to more consistently fail across all runs.
- Removes unused methods / reduces visibility to appease errorprone
checks for broken JUnit 4 test method definitions.
---
.github/workflows/build.yml | 2 +-
pom.xml | 2 +-
.../failover/FailoverConsumerOutstandingCommitTest.java | 5 -----
.../activemq/transport/failover/FailoverDuplicateTest.java | 12 +-----------
.../transport/failover/FailoverPrefetchZeroTest.java | 5 -----
5 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 09d1197134..925b243b5e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -118,7 +118,7 @@ jobs:
if: matrix.java != '17'
run: |
cd activemq-artemis
- mvn -s .github/maven-settings.xml -DskipTests -Derrorprone -Pdev
-Pjmh install
+ mvn -s .github/maven-settings.xml -DskipTests -Derrorprone -Pdev
-Pjmh -Popenwire-tests -DskipActiveMQ5Tests install
- name: Set Examples Version to Artemis Version
run: |
diff --git a/pom.xml b/pom.xml
index f8eda1da74..480a6a49e5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -110,7 +110,7 @@
<jetty.version>12.0.23</jetty.version>
<jetty-servlet-api.version>5.0.2</jetty-servlet-api.version>
<jgroups.version>5.3.13.Final</jgroups.version>
- <errorprone.version>2.39.0</errorprone.version>
+ <errorprone.version>2.40.0</errorprone.version>
<maven.bundle.plugin.version>5.1.9</maven.bundle.plugin.version>
<jib.maven.plugin.version>3.4.6</jib.maven.plugin.version>
<versions.maven.plugin.version>2.16.1</versions.maven.plugin.version>
diff --git
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
index 7e0a651304..8b62fc5e81 100644
---
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
+++
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverConsumerOutstandingCommitTest.java
@@ -67,11 +67,6 @@ public class FailoverConsumerOutstandingCommitTest extends
OpenwireArtemisBaseTe
}
}
- public void startServer() throws Exception {
- server = createBroker();
- server.start();
- }
-
@Test
@BMRules(
rules = {@BMRule(
diff --git
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
index de37dc3101..9b2bd3496e 100644
---
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
+++
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverDuplicateTest.java
@@ -64,22 +64,12 @@ public class FailoverDuplicateTest extends
OpenwireArtemisBaseTest {
stopBroker();
}
- public void stopBroker() throws Exception {
+ protected void stopBroker() throws Exception {
if (broker != null) {
broker.stop();
}
}
- public void startBroker(boolean deleteAllMessagesOnStartup) throws
Exception {
- broker = createBroker();
- broker.start();
- }
-
- public void startBroker() throws Exception {
- broker = createBroker();
- broker.start();
- }
-
public void configureConnectionFactory(ActiveMQConnectionFactory factory) {
factory.setAuditMaximumProducerNumber(2048);
factory.setOptimizeAcknowledge(true);
diff --git
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
index 42a513e96b..60b72941c2 100644
---
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
+++
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/failover/FailoverPrefetchZeroTest.java
@@ -66,11 +66,6 @@ public class FailoverPrefetchZeroTest extends
OpenwireArtemisBaseTest {
}
}
- public void startBroker() throws Exception {
- broker = createBroker();
- broker.start();
- }
-
@Test
@BMRules(
rules = {@BMRule(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
