This is an automated email from the ASF dual-hosted git repository.
tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new 5b36358841 ARTEMIS-5612 unable to disable queue metrics
5b36358841 is described below
commit 5b36358841bb0bfc49b01301999d15ed238ee1d2
Author: Justin Bertram <[email protected]>
AuthorDate: Thu Aug 7 14:50:32 2025 -0500
ARTEMIS-5612 unable to disable queue metrics
---
.../activemq/artemis/core/server/metrics/MetricsManager.java | 2 +-
.../activemq/artemis/core/server/metrics/MetricsManagerTest.java | 7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java
index 8cef9101af..d3ed24eeb1 100644
---
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java
+++
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java
@@ -118,7 +118,7 @@ public class MetricsManager {
}
public void registerQueueGauge(String address, String queue,
Consumer<MetricGaugeBuilder> builder) {
- if (this.meterRegistry == null ||
!addressSettingsRepository.getMatch(queue).isEnableMetrics()) {
+ if (this.meterRegistry == null ||
!addressSettingsRepository.getMatch(address).isEnableMetrics()) {
return;
}
final List<Builder<Object>> gaugeBuilders = new ArrayList<>();
diff --git
a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/metrics/MetricsManagerTest.java
b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/metrics/MetricsManagerTest.java
index 782605e46d..013202a23f 100644
---
a/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/metrics/MetricsManagerTest.java
+++
b/artemis-server/src/test/java/org/apache/activemq/artemis/core/server/metrics/MetricsManagerTest.java
@@ -42,15 +42,18 @@ public class MetricsManagerTest {
}
public void testQueueMetrics(boolean enableMetrics) throws Exception {
+ final String address = RandomUtil.randomAlphaNumericString(4);
+ final String queue = RandomUtil.randomAlphaNumericString(4);
HierarchicalRepository<AddressSettings> addressSettingsRepository = new
HierarchicalObjectRepository<>(new WildcardConfiguration());
- addressSettingsRepository.addMatch("#", new
AddressSettings().setEnableMetrics(enableMetrics));
+ addressSettingsRepository.addMatch("#", new
AddressSettings().setEnableMetrics(!enableMetrics));
+ addressSettingsRepository.addMatch(address, new
AddressSettings().setEnableMetrics(enableMetrics));
MetricsConfiguration metricsConfiguration = new MetricsConfiguration();
metricsConfiguration.setPlugin(new SimpleMetricsPlugin().init(null));
MetricsManager metricsManager = new
MetricsManager(RandomUtil.randomUUIDString(), metricsConfiguration,
addressSettingsRepository, null);
AtomicBoolean test = new AtomicBoolean(false);
-
metricsManager.registerQueueGauge(RandomUtil.randomAlphaNumericString(4),
RandomUtil.randomAlphaNumericString(4), (builder) -> {
+ metricsManager.registerQueueGauge(address, queue, (builder) -> {
test.set(true);
});
assertEquals(enableMetrics, test.get());
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
