This is an automated email from the ASF dual-hosted git repository.

clebertsuconic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/main by this push:
     new 691e517781 ARTEMIS-5764 remove a couple unused methods in 
ActiveMQServerImpl
691e517781 is described below

commit 691e517781d978d2889804110462eba0b862f304
Author: Justin Bertram <[email protected]>
AuthorDate: Fri Nov 14 12:47:26 2025 -0600

    ARTEMIS-5764 remove a couple unused methods in ActiveMQServerImpl
---
 .../core/server/impl/ActiveMQServerImpl.java       | 31 +---------------------
 1 file changed, 1 insertion(+), 30 deletions(-)

diff --git 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
index 8597936a57..92dc97ef52 100644
--- 
a/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
+++ 
b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
@@ -16,6 +16,7 @@
  */
 package org.apache.activemq.artemis.core.server.impl;
 
+import javax.management.MBeanServer;
 import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
@@ -53,11 +54,8 @@ import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.function.Consumer;
-import java.util.function.Supplier;
 import java.util.stream.Collectors;
 
-import javax.management.MBeanServer;
-
 import org.apache.activemq.artemis.api.config.ActiveMQDefaultConfiguration;
 import org.apache.activemq.artemis.api.core.ActiveMQDeleteAddressException;
 import org.apache.activemq.artemis.api.core.ActiveMQException;
@@ -4652,33 +4650,6 @@ public class ActiveMQServerImpl implements 
ActiveMQServer {
       }
    }
 
-   private static <T> void setDefaultIfUnset(Supplier<T> getter, Consumer<T> 
setter, T defaultValue) {
-      if (getter.get() == null) {
-         setter.accept(defaultValue);
-      }
-   }
-
-   private static void setUnsetQueueParamsToDefaults(QueueConfiguration c) {
-      // Param list taken from PostOfficeImpl::updateQueue
-      setDefaultIfUnset(c::getMaxConsumers, c::setMaxConsumers, 
ActiveMQDefaultConfiguration.getDefaultMaxQueueConsumers());
-      setDefaultIfUnset(c::getRoutingType, c::setRoutingType, 
ActiveMQDefaultConfiguration.getDefaultRoutingType());
-      setDefaultIfUnset(c::isPurgeOnNoConsumers, c::setPurgeOnNoConsumers, 
ActiveMQDefaultConfiguration.getDefaultPurgeOnNoConsumers());
-      setDefaultIfUnset(c::isEnabled, c::setEnabled, 
ActiveMQDefaultConfiguration.getDefaultEnabled());
-      setDefaultIfUnset(c::isExclusive, c::setExclusive, 
ActiveMQDefaultConfiguration.getDefaultExclusive());
-      setDefaultIfUnset(c::isGroupRebalance, c::setGroupRebalance, 
ActiveMQDefaultConfiguration.getDefaultGroupRebalance());
-      setDefaultIfUnset(c::getGroupBuckets, c::setGroupBuckets, 
ActiveMQDefaultConfiguration.getDefaultGroupBuckets());
-      setDefaultIfUnset(c::getGroupFirstKey, c::setGroupFirstKey, 
ActiveMQDefaultConfiguration.getDefaultGroupFirstKey());
-      setDefaultIfUnset(c::isNonDestructive, c::setNonDestructive, 
ActiveMQDefaultConfiguration.getDefaultNonDestructive());
-      setDefaultIfUnset(c::getConsumersBeforeDispatch, 
c::setConsumersBeforeDispatch, 
ActiveMQDefaultConfiguration.getDefaultConsumersBeforeDispatch());
-      setDefaultIfUnset(c::getDelayBeforeDispatch, c::setDelayBeforeDispatch, 
ActiveMQDefaultConfiguration.getDefaultDelayBeforeDispatch());
-      setDefaultIfUnset(c::getFilterString, c::setFilterString, 
SimpleString.of(""));
-      // Defaults to false automatically as per isConfigurationManaged() 
JavaDoc
-      setDefaultIfUnset(c::isConfigurationManaged, c::setConfigurationManaged, 
false);
-      // Setting to null might have side effects
-      setDefaultIfUnset(c::getUser, c::setUser, null);
-      setDefaultIfUnset(c::getRingSize, c::setRingSize, 
ActiveMQDefaultConfiguration.getDefaultRingSize());
-   }
-
    private void deployReloadableConfigFromConfiguration() throws Exception {
       if (configurationReloadDeployed.compareAndSet(false, true)) {
          ActiveMQServerLogger.LOGGER.reloadingConfiguration("security 
settings");


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to