This is an automated email from the ASF dual-hosted git repository.
cshannon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq.git
The following commit(s) were added to refs/heads/main by this push:
new 6060f9bcd3 Improve PortfolioPublishServlet encoding (#1745)
6060f9bcd3 is described below
commit 6060f9bcd3b38c47225db1162260be6309590c44
Author: Christopher L. Shannon <[email protected]>
AuthorDate: Mon Mar 9 14:01:40 2026 -0400
Improve PortfolioPublishServlet encoding (#1745)
Use HTML encoding for output instead of URL encoding
---
.../java/org/apache/activemq/web/PortfolioPublishServlet.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
a/activemq-web/src/main/java/org/apache/activemq/web/PortfolioPublishServlet.java
b/activemq-web/src/main/java/org/apache/activemq/web/PortfolioPublishServlet.java
index 2d135d6821..e73229eb58 100644
---
a/activemq-web/src/main/java/org/apache/activemq/web/PortfolioPublishServlet.java
+++
b/activemq-web/src/main/java/org/apache/activemq/web/PortfolioPublishServlet.java
@@ -28,6 +28,7 @@ import jakarta.jms.Session;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
+import org.springframework.web.util.HtmlUtils;
/**
* A servlet which will publish dummy market data prices
@@ -75,8 +76,9 @@ public class PortfolioPublishServlet extends
MessageServletSupport {
out.println("</body></html>");
} catch (JMSException e) {
- out.println("<html><body>Failed sending price messages due to
<b>" + e + "</b></body></html>");
- log("Failed to send message: " + e, e);
+ String errorMessage = e.getMessage();
+ out.println("<html><body>Failed sending price messages due to
<b>" + escape(errorMessage) + "</b></body></html>");
+ log("Failed to send message: " + errorMessage, e);
}
}
}
@@ -132,6 +134,6 @@ public class PortfolioPublishServlet extends
MessageServletSupport {
}
protected String escape(String text) throws IOException {
- return java.net.URLEncoder.encode(text, "UTF-8");
+ return text != null ? HtmlUtils.htmlEscape(text, "UTF-8") : null;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
