jrgemignani commented on code in PR #1022:
URL: https://github.com/apache/age/pull/1022#discussion_r1260053786
##########
src/backend/executor/cypher_utils.c:
##########
@@ -248,6 +248,8 @@ HeapTuple insert_entity_tuple_cid(ResultRelInfo
*resultRelInfo,
}
// Insert the tuple normally
+ // TODO
Review Comment:
Thanks for catching that! I added it to check whether the following line was
needed or not.
##########
src/backend/parser/cypher_expr.c:
##########
@@ -296,14 +301,14 @@ static Node *transform_WholeRowRef(ParseState *pstate,
RangeTblEntry *rte,
static Node *transform_ColumnRef(cypher_parsestate *cpstate, ColumnRef *cref)
{
ParseState *pstate = (ParseState *)cpstate;
- RangeTblEntry *rte = NULL;
Node *field1 = NULL;
Node *field2 = NULL;
char *colname = NULL;
char *nspname = NULL;
char *relname = NULL;
Node *node = NULL;
int levels_up;
+ ParseNamespaceItem *pnsi;
Review Comment:
While it isn't absolutely necessary, because pnsi is actually set on every
path, we should be consistent with how a function "looks".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
