jrgemignani commented on code in PR #1135:
URL: https://github.com/apache/age/pull/1135#discussion_r1293958202
##########
src/backend/utils/adt/agtype.c:
##########
@@ -2377,7 +2378,9 @@ static agtype_value*
agtype_build_map_as_agtype_value(FunctionCallInfo fcinfo)
nargs = extract_variadic_args(fcinfo, 0, true, &args, &types, &nulls);
if (nargs < 0)
- PG_RETURN_NULL();
+ {
+ return NULL;
Review Comment:
It should be NULL. This is a static function that isn't called externally to
this file. All the functions calling it are expecting NULL or an agtype_value
to be returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
