rafsun42 commented on PR #1179: URL: https://github.com/apache/age/pull/1179#issuecomment-1787608898
@markgomer Looks good to me. One thing that concerns me is that the `agload` test is taking way longer than other tests since it is now loading the csv files many times. So, I looked at the tests you added to see if we can remove some of them. For the sake of speeding the test, otherwise they were fine. Should we remove these two groups of tests? - Tests without creating labels first, without id field - TEST DOUBLE LOAD files My justification is- the changes you made does not affect the algorithm of 'without id field' and 'double load' directly. So it may be okay to not tests these functionalities at least in this PR. You are changes are tested by the first group of tests you added, where you check if the label was actually created and the number of rows in the labels using the COUNT function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
