rafsun42 commented on code in PR #1742:
URL: https://github.com/apache/age/pull/1742#discussion_r1561860383
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context
*ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
Overall looks good. Just a quick question. Does `!insert` always imply a
`WARNING` instead of an `ERROR`?
##########
src/backend/utils/adt/age_global_graph.c:
##########
@@ -568,11 +610,13 @@ static void load_edge_hashtable(GRAPH_global_context
*ggctx)
/* insert the edge into the start and end vertices edge lists */
inserted = insert_vertex_edge(ggctx, edge_vertex_start_id,
- edge_vertex_end_id, edge_id);
- /* this insert must not fail */
+ edge_vertex_end_id, edge_id,
+ edge_label_name);
if (!inserted)
Review Comment:
Overall looks good. Just a quick question. Does `!inserted` always imply a
`WARNING` instead of an `ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
