dehowef commented on PR #1793:
URL: https://github.com/apache/age/pull/1793#issuecomment-2084486704

   > @mhmaguire scratch my previous comment-- User error on my part! I'll 
continue reviewing this when I find a moment
   
   Lol okay actually sorry to walk back my comment again, but when I run the 
unittests via "python -m unittest -v test_age_.py" and python -m unittest -v 
test_networkx.py as stated in the documentation, they throw an attribute error 
as follows:
   
   Traceback (most recent call last):
     File "/home/user/age/drivers/python/test_age_py.py", line 36, in setUp
       host=self.args.host,
            ^^^^^^^^^
   AttributeError: 'TestAgeBasic' object has no attribute 'args'
   
   The unit tests still run fine if I call them directly, but I think it'd be a 
relatively easy fix to get this error to disappear. Would you mind amending 
your commit so that they work with these unit test commands? Otherwise it looks 
great and I appreciate what you've done here. I think after that change, I'll 
give it another once over and probably good to go. @mhmaguire 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to