MironAtHome commented on PR #2037: URL: https://github.com/apache/age/pull/2037#issuecomment-2285030514
> (it could be a mistake from the migration away from Oids, btw) Any additional guidance would be appreciated. If the actual plan is to migrate away from Oid type, I will create one more PR with unsigned int of 32 bit size (uint32). In this, provided PR, the goal was to ensure that function declaration matches function definition and usage. Plus get_graph_oid function name seems to carry reference to type oid. If return type and usage in this planned PR to change away frm Oid, I would propose renaming function to get_graph_id, with new moniker "id" suggesting type independent treatment of graph numerical identifier used by graph database catalogue internally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
