MuhammadTahaNaveed commented on code in PR #2213: URL: https://github.com/apache/age/pull/2213#discussion_r2319510146
########## RELEASE: ########## @@ -15,65 +15,101 @@ # specific language governing permissions and limitations # under the License. -Release Notes for Apache AGE release 1.5.0 for PostgreSQL version 16 +Release Notes for Apache AGE release 1.6.0 for master branch (currently PG17) -Apache AGE 1.5.0 - Release Notes +# +# WARNING! +# +# Since there are modifications to agtype gin operators, users who are +# upgrading will need to drop the gin indexes before running the upgrade +# script and recreate them afterwards. +# Review Comment: If you could add the following line here: "Please backup your db before upgrading" ########## RELEASE: ########## @@ -15,65 +15,101 @@ # specific language governing permissions and limitations # under the License. -Release Notes for Apache AGE release 1.5.0 for PostgreSQL version 16 +Release Notes for Apache AGE release 1.6.0 for master branch (currently PG17) Review Comment: Should be PG16 ########## docker/Dockerfile: ########## @@ -48,9 +48,9 @@ ENV LANG=en_US.UTF-8 ENV LC_COLLATE=en_US.UTF-8 ENV LC_CTYPE=en_US.UTF-8 -COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/16/lib/ -COPY --from=build /usr/share/postgresql/16/extension/age--1.5.0.sql /usr/share/postgresql/16/extension/ -COPY --from=build /usr/share/postgresql/16/extension/age.control /usr/share/postgresql/16/extension/ +COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/17/lib/ Review Comment: should be 16 ########## docker/Dockerfile: ########## @@ -48,9 +48,9 @@ ENV LANG=en_US.UTF-8 ENV LC_COLLATE=en_US.UTF-8 ENV LC_CTYPE=en_US.UTF-8 -COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/16/lib/ -COPY --from=build /usr/share/postgresql/16/extension/age--1.5.0.sql /usr/share/postgresql/16/extension/ -COPY --from=build /usr/share/postgresql/16/extension/age.control /usr/share/postgresql/16/extension/ +COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/17/lib/ +COPY --from=build /usr/share/postgresql/16/extension/age--1.6.0.sql /usr/share/postgresql/17/extension/ +COPY --from=build /usr/share/postgresql/16/extension/age.control /usr/share/postgresql/17/extension/ Review Comment: should be 16 ########## age--1.5.0--1.6.0.sql: ########## @@ -17,16 +17,29 @@ * under the License. */ --- This is a template for upgrading from the previous version of Apache AGE --- It will only work within versions of PostgreSQL, not across. --- Please adjust the below ALTER EXTENSION to reflect the correct version --- it is upgrading to. +--* This is a TEMPLATE for upgrading from the previous version of Apache AGE Review Comment: Template comments should be removed from this file. ########## docker/Dockerfile: ########## @@ -48,9 +48,9 @@ ENV LANG=en_US.UTF-8 ENV LC_COLLATE=en_US.UTF-8 ENV LC_CTYPE=en_US.UTF-8 -COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/16/lib/ -COPY --from=build /usr/share/postgresql/16/extension/age--1.5.0.sql /usr/share/postgresql/16/extension/ -COPY --from=build /usr/share/postgresql/16/extension/age.control /usr/share/postgresql/16/extension/ +COPY --from=build /usr/lib/postgresql/16/lib/age.so /usr/lib/postgresql/17/lib/ +COPY --from=build /usr/share/postgresql/16/extension/age--1.6.0.sql /usr/share/postgresql/17/extension/ Review Comment: should be 16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
