jrgemignani commented on code in PR #2286:
URL: https://github.com/apache/age/pull/2286#discussion_r2669386983
##########
Makefile:
##########
@@ -150,8 +157,12 @@ src/backend/parser/cypher_gram.c: BISONFLAGS +=
--defines=src/include/parser/cyp
src/backend/parser/cypher_parser.o: src/backend/parser/cypher_gram.c
src/backend/parser/cypher_keywords.o: src/backend/parser/cypher_gram.c
-$(age_sql):
+# Strip PASSEDBYVALUE on 32-bit (SIZEOF_DATUM=4) for graphid pass-by-reference
+$(age_sql): $(SQLS)
@cat $(SQLS) > $@
+ifeq ($(SIZEOF_DATUM),4)
+ @sed 's/^[[:space:]]*PASSEDBYVALUE,$$/ -- PASSEDBYVALUE removed for
32-bit/' $@ > [email protected] && mv [email protected] $@
Review Comment:
@jpabbuehl Thoughts? Btw, I'm just using the AI tools as a double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
