uesleilima commented on PR #2374: URL: https://github.com/apache/age/pull/2374#issuecomment-4194881147
All review feedback has been addressed: **tcolo's review:** - ✅ Moved `TypeInfo.fetch()` inside the cursor block so `search_path` change is visible regardless of transaction isolation. - ✅ `ValueError` raised when `load_from_plugins=True` but `load=False`. - ✅ Added type annotations to `configure_connection` signature. - ✅ Documented shallow-copy semantics in `Vertex.to_dict()` and `Edge.to_dict()`. - ✅ Added test for `AgeNotSet` when `TypeInfo.fetch` returns `None`. - ✅ Replaced fragile string assertions with `assert_called_with` / `assert_any_call`. **Copilot review:** - ✅ Fixed `Path.to_dict()`: JSON-native types (dict, list, str, int, float, bool, None) now pass through unchanged; `str()` is only used as a safety net for non-serializable objects. Also handles `entities=None` safely. - ✅ Added `TestModelToDict`, `TestPublicImports`, `TestConfigureConnection` to the `__main__` suite so they run via direct script execution. - ⚠️ `configure_connection()` duplicating `setUpAge()`: Valid observation but refactoring scope is too large for this PR. Happy to address in a follow-up. - ⚠️ PR description mentions `skip_load` but API uses `load`: This is intentional — `configure_connection(load=False)` uses positive opt-in semantics (`load=True` to enable), unlike `setUpAge(skip_load=True)` which uses opt-out. The distinction is documented in the docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
