uesleilima commented on PR #2373: URL: https://github.com/apache/age/pull/2373#issuecomment-4194880837
All review feedback has been addressed: **tcolo's review:** - ✅ Added comment explaining why `type_name` is intentionally left unquoted (PostgreSQL case-folding semantics). - ✅ Fixed `graphName == None` to idiomatic `graphName is None`. - ✅ Replaced fragile `assertNotIn` with regex assertion. - ✅ Added comment explaining intentional `_validate_column` private import. - ✅ Added test for reserved word in `"name type"` pair (e.g., `"order agtype"`). **Copilot review:** - ✅ **Fixed CI failure**: Updated `test_security.py` assertions to expect double-quoted column names (matching the always-quote change). - ✅ Improved `type_name` comment wording to clarify case-folding semantics. - ⚠️ Case-folding behavior change (uppercase identifiers become case-sensitive): This is inherent to the fix — the `validate_identifier()` regex only accepts `[A-Za-z_][A-Za-z0-9_]*` identifiers, and PostgreSQL treats double-quoted identifiers as case-sensitive. This is the correct trade-off for preventing reserved-word parse errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
