uesleilima commented on PR #2372:
URL: https://github.com/apache/age/pull/2372#issuecomment-4194880485
All review feedback has been addressed:
**tcolo's review:**
- ✅ `visitFloatLiteral`: now raises `AGTypeError` on malformed child node
instead of silent fallback.
- ✅ `handleAnnotatedValue`: added comment explaining partial-construction
behavior.
- ✅ `visitObj`/`visitPair`: added comment documenting that `visitPair`'s
validation makes the None-guard defensive-only.
- ✅ `pyproject.toml`: added inline comment explaining ANTLR4 version range
rationale.
- ✅ Malformed/truncated input tests now assert `AGTypeError` or validate
recovery shape (not just absence of `AttributeError`).
**Copilot review:**
- ✅ Vertex and edge branches now default `properties` to `{}` via
`d.get("properties") or {}`, preventing `__getitem__` crashes.
- ✅ Replaced weak `assertNotIsInstance(result, type(NotImplemented))` with
structural type checks.
- ✅ Fixed `test_truncated_agtype` docstring to match actual assertion
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
