uesleilima commented on PR #2366: URL: https://github.com/apache/age/pull/2366#issuecomment-4194880265
All review feedback has been addressed: **tcolo's review:** - ✅ `skip_load` is already explicitly named in `__init__.py:connect()` and `Age.connect()` — no kwargs leak. - ✅ Added `ValueError` for contradictory `skip_load=True + load_from_plugins=True`. - ✅ Added end-to-end test verifying `skip_load` is forwarded through the full `age.connect() → Age.connect() → setUpAge()` call chain. - ✅ README now mentions `setUpAge(skip_load=True)` for pool-based setups. - ✅ Replaced fragile string assertions with `assert_called_with` / `assert_any_call`. **Copilot review:** - ✅ Fixed README: removed `configure_connection()` reference (not part of this branch); now uses `setUpAge(conn, 'graph_name', skip_load=True)` for the pool example. - ⚠️ `connection_factory` being unused is a pre-existing issue, out of scope for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
