jrgemignani opened a new pull request, #2377:
URL: https://github.com/apache/age/pull/2377

   Note: This PR was created with AI tools and a human.
   
   This is an addendum to PR #2364 with three improvements.
   
   Makefile:
   - Replace awk-based synthetic version (minor+1) with an _upgrade_test suffix 
(e.g., 1.7.0 -> 1.7.0_upgrade_test). The awk approach produced numeric versions 
like 1.8.0 that could collide with real future upgrade scripts, and the ::int[] 
cast in the SQL version lookup fails on non-numeric version strings. The 
_upgrade_test suffix avoids both issues and is unambiguously synthetic.
   - Extend the generated cleanup script to also remove repo-root copies of the 
synthetic files and to self-delete, preventing stale artifacts from 
accumulating across repeated test runs.
   
   Regression test (regress/sql/age_upgrade.sql):
   - Simplify version lookup to directly select the _upgrade_test version via 
LIKE '%_upgrade_test' instead of picking the highest non-default version with 
string_to_array(version, '.')::int[] DESC. The old approach would fail with a 
cast error on the _upgrade_test suffix and was unnecessarily indirect — the 
test knows exactly what synthetic version the Makefile installed.
   
   modified:   Makefile
   modified:   regress/expected/age_upgrade.out
   modified:   regress/sql/age_upgrade.sql


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to