crprashant commented on PR #2411: URL: https://github.com/apache/age/pull/2411#issuecomment-4301226842
Heads-up for reviewers — just noticed @MuhammadTahaNaveed's #2406 fixes the same root cause (agtype `AGTV_NULL` not being emitted as SQL NULL from `age_unnest`) with a broader scope that also covers `single()` / `all()` / `any()` / `none()` three-valued semantics. That direction was my first instinct too, but I backed off after it altered the `predicate_functions` regression; #2406 goes further and reworks those predicates to match Neo4j three-valued logic, which is the right call. #2406 subsumes this PR. Happy to close #2411 in favor of #2406 once it lands. The 7 regression cases in `regress/sql/cypher_unwind.sql` here specifically cover `UNWIND [null] AS x RETURN count(x) = 0` (issue #2383) and a few `UNWIND`-only boundaries (nested lists, mixed nulls, `DISTINCT` over `UNWIND`) that #2406's tests don't exercise — glad to open a small follow-up PR porting just those tests on top of #2406 if that would be useful. Thanks for the fast work on the null-propagation family of bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
