jrgemignani commented on PR #2410: URL: https://github.com/apache/age/pull/2410#issuecomment-4330609401
@sfc-gh-dachristensen Please add the following - - Add a regression test - without this, a future refactor could reintroduce the bug. - The value 400 seems a bit arbitrary. Why not some constant or number that feels less like a magic number? Fx, 512. - Add a comment at the buffer declaration explaining the need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
