gregfelice commented on PR #2406: URL: https://github.com/apache/age/pull/2406#issuecomment-4812666483
@jrgemignani — a couple of cross-cutting notes from going through the open parser/agtype PRs, in case they help with sequencing: **1. #2406 and #2411 are competing fixes for the same `UNWIND [null]` bug (#2383).** They take opposite approaches and will conflict — whichever lands first forces a rework of the other: - **#2411** is surgical: a separate `age_unwind` SRF, with only `transform_cypher_unwind` repointed to it. `age_unnest` is untouched, so list comprehensions and predicate functions can't regress. The trade-off is it *intentionally* leaves the related list-comprehension null-filter bug (#2393) and the predicate-function three-valued logic unfixed, since those callers currently rely on `agtype_null > agtype_integer` being truthy. - **#2406** (this PR) is root-cause: it fixes `age_unnest` itself and rewrites the predicate-function 3VL so that truthy-null quirk becomes proper three-valued logic — fixing UNWIND, list comprehensions (#2393), and `single()` together. Per openCypher, `null > 0` should be `null` rather than truthy, so this PR is the more correct end state; #2411 is the smaller, lower-risk step. Both are sound for their stated scope — it's really a scoping call on whether to fix the whole null-handling family at once or just the UNWIND symptom. Flagging so they don't both get merged independently. **2. A few of these are blocked more on process than on code.** - **No CI run:** #2411 and #2412 don't show any check runs — the contributor branches likely need a maintainer to kick off the workflow (or a push) before they can be evaluated for merge. - **Need a rebase:** #2295 and #2411 are currently CONFLICTING with master. #2295 in particular dates to Dec 2025 and touches parser/agtype areas that have moved a lot since, so it'll want a rebase + fresh green CI before a real merge pass. Happy to take another look at any of these once they're rebased / CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
