gregfelice commented on PR #2469:
URL: https://github.com/apache/age/pull/2469#issuecomment-4972867049
Heads up @mmustafasenoglu — CI had never actually run on this branch (the
workflow runs were sitting unapproved, which is why the PR showed no checks).
I've approved them, and **Build / Regression now fails**.
The cause is a missing expected-output regeneration. The new pipe-delimited
cases were added to `regress/sql/age_load.sql`, but
`regress/expected/age_load.out` was not updated to match, so `pg_regress` diffs
the new output against an expected file that does not contain it:
```
diff -U3 regress/expected/age_load.out regress/results/age_load.out
@@ -512,6 +512,65 @@
+--
+-- Test delimiter parameter for pipe-delimited files
+--
+SELECT create_graph('agload_pipe');
+NOTICE: graph "agload_pipe" has been created
...
```
Regenerating `regress/expected/age_load.out` from a clean run should clear
it. Worth re-checking the whole file rather than pasting just the new block, so
the surrounding row counts and NOTICE ordering stay consistent.
Ping me once CI is green and I'll review the change itself — I have not
looked at the delimiter handling yet, only at why the build was red.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
