gregfelice commented on PR #2468: URL: https://github.com/apache/age/pull/2468#issuecomment-5024746241
Filed #2479 to track the scan-plan issue independently of this PR, with the mechanism written up in full (parser sets `rel->label = NULL` → fallback to `_ag_label_edge` → inheritance expansion across all edge label tables → function-wrapped `_extract_label_id(id) IN (...)` that the planner can't prune on). To be clear about what that does and doesn't change here: the issue is a tracking artifact, not the scope-out itself. If the preference is to land this PR as-is and address the plan shape separately, that still needs a benchmark showing the cost at realistic edge-label counts — that's the part I'd want to see before the block comes off, and it's the piece I can't supply on the author's behalf since it depends on how you intend the feature to be used. If instead you'd rather fix it in this PR, #2479 has the suggested direction (Append/Union over the resolved labels' own `RangeVar`s, reusing the per-label lookup the single-label path already does). Either way works for me, and I'll re-review promptly. @jrgemignani — this should also cover the performance question you raised on Jul 13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
