Copilot commented on code in PR #2522: URL: https://github.com/apache/age/pull/2522#discussion_r3809173365
########## docker/hooks/build: ########## @@ -1,4 +1,7 @@ #!/bin/bash -docker buildx create --name multiarch --use --platform linux/amd64,linux/arm64/v8 -docker buildx build ../ -t $IMAGE_NAME -f Dockerfile --platform linux/amd64,linux/arm64/v8 --push \ No newline at end of file +# Pinned: buildx-stable-1 ships runc 1.4.3, which fails masked-path setup on the build host (runc#5348). +docker buildx create --name multiarch --use --platform linux/amd64,linux/arm64/v8 \ + --driver-opt image=moby/buildkit:v0.31.2 Review Comment: `--driver-opt image=...` is specific to the `docker-container` buildx driver. To avoid failures in environments where the default driver is not `docker-container`, explicitly set the driver when creating the builder. ########## docker/hooks/build: ########## @@ -1,4 +1,7 @@ #!/bin/bash -docker buildx create --name multiarch --use --platform linux/amd64,linux/arm64/v8 -docker buildx build ../ -t $IMAGE_NAME -f Dockerfile --platform linux/amd64,linux/arm64/v8 --push \ No newline at end of file +# Pinned: buildx-stable-1 ships runc 1.4.3, which fails masked-path setup on the build host (runc#5348). +docker buildx create --name multiarch --use --platform linux/amd64,linux/arm64/v8 \ + --driver-opt image=moby/buildkit:v0.31.2 + +docker buildx build ../ -t $IMAGE_NAME -f Dockerfile --platform linux/amd64,linux/arm64/v8 --push Review Comment: `$IMAGE_NAME` is expanded unquoted, which can cause word-splitting/globbing issues and makes it harder to diagnose missing tags. Quote it and fail fast if it’s unset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
