crdv7 commented on PR #2517: URL: https://github.com/apache/age/pull/2517#issuecomment-5372839971
> Some concerns: > > * SET memory appears to grow significantly when the label has a stored generated column. On the patchd build, the plain label case peaked around 56 MB RSS, while the generated column case reached roughly 743 MB. > * Duplcate MERGE rows appear to retain the `prebuilt_path_array` container because only its entries are freed, causing memory usage to grow with the number of duplicate rows. > * The DELETE expression context resets cover input rows, but the connected edge RLS checks apear to run without a reset between edges. > > Also, the attached benchmark runner does not implement the five run AB/BA process described in the PR, and its private memory sampling is fairly sparse for the shorter patched runs. This does not invalidate the performance improvement, but it makes the exact reported figures difficult to reproduce. Thanks for the detailed review. I have force-pushed amended commit `560609e8` with the three fixes above. The previous benchmark attachment was my mistake: I uploaded an internal AB/BA runner that required two manually prepared builds. I have replaced it with a self-contained runner that can be executed without arguments: [reproduce_write_memory_benchmark.sh](https://github.com/user-attachments/files/31311914/reproduce_write_memory_benchmark.sh) ```bash ./reproduce_write_memory_benchmark.sh ``` With no source options, it downloads PostgreSQL 18.4 and AGE, then builds baseline AGE `801417404978823bd8732452c3f7959017584785` and patched AGE `560609e8092b0050dd026cb01e84fb2e6a1aff2a`. The runner starts isolated instances, runs five AB/BA-interleaved trials, samples private memory every 10 ms, and prints the final tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
