jrgemignani commented on PR #2577: URL: https://github.com/apache/age/pull/2577#issuecomment-5799958441
**Thumbs up for [PR #2577](https://github.com/apache/age/pull/2577) at `4328c8e5`. No introduced blocking defect found.** ## Findings 1. **Nonblocking: explain the intentional no-op update.** The [`pg_opclass` update](https://github.com/apache/age/blob/4328c8e50c5344576c349d2a7d84a03c6c15ceb8/age--1.8.0--y.y.y.sql#L96) is necessary to invalidate cached ordering operators. Add a comment so it is not later removed as redundant. 2. **Release caveat: existing databases need an actual upgrade.** The repair resides in a future-upgrade template, excluded from normal installation. Shipping these files alone will not repair an existing AGE 1.8.0 database. A concrete versioned upgrade must include and execute the repair. ## Correctness The fix correctly assigns B-tree strategy **4 to `>=` and 5 to `>`**. Temporary strategy numbers avoid uniqueness conflicts, and operator-identity-based restoration handles the expected old and already-correct mappings. Existing indexes do **not** need rebuilding: their comparison function and physical ordering are unchanged. The bot's missing-`ELSE` comment is **not a demonstrated High-severity defect**. Normal AGE catalogs contain the two operators covered by the `CASE`. An unexpected operator would fail the NOT NULL constraint and roll back, rather than silently corrupt the mapping. ## Independent Validation On the exact PR head, using private PostgreSQL **18.6 with assertions enabled**: - Clean build with `COPT=-Werror`: **zero compiler diagnostics**. - Focused `scan`, `index`, `age_upgrade`: **3/3 passed**. - Complete core regression suite: **43/43 passed**. - Prepared descending sorts remained correct through upgrade, rollback, and re-upgrade. - Existing index OID and storage file remained unchanged. - Indexed `>= 2` retained both duplicate boundary values; `> 2` excluded them. Five independent profile-driven specialist reviews and coordinator reconciliation completed. ## Limits Optional extensions, assertion-disabled builds, and cross-backend upgrade concurrency were not independently tested. This recommendation applies to the reviewed change, not unconditional release certification. No PR comments, votes, or tracked source changes were made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
