potiuk commented on a change in pull request #4350: [AIRFLOW-3527] Cloud SQL
Proxy has shorter path for UNIX socket
URL: https://github.com/apache/incubator-airflow/pull/4350#discussion_r245113784
##########
File path: airflow/contrib/hooks/gcp_sql_hook.py
##########
@@ -437,8 +442,8 @@ def _download_sql_proxy_if_needed(self):
download_url = CLOUD_SQL_PROXY_VERSION_DOWNLOAD_URL.format(
self.sql_proxy_version, system, processor)
proxy_path_tmp = self.sql_proxy_path + ".tmp"
- self.log.info("Downloading cloud_sql_proxy from {} to {}".
- format(download_url, proxy_path_tmp))
+ self.log.info("Downloading cloud_sql_proxy from %s to %s" %
Review comment:
Stupid me - it would not indeed work this way for optimising parameter
evaluation, quite obvious but somehow I missed it. It's fixed now in latest push
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
