feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168050
########## File path: airflow/www/templates/airflow/dag.html ########## @@ -320,6 +326,29 @@ <h4 class="modal-title" id="dagModalLabel"> $("#div_btn_subdag").show(); subdag_id = "{{ dag.dag_id }}."+t; } + + $("#try_index > li").remove() + var startIndex = (try_numbers > 2 ? 0 : 1) + for (var index = startIndex; index < try_numbers; index++) { + var url = "{{ url_for('airflow.get_logs_with_metadata') }}" + + "?dag_id=" + encodeURIComponent(dag_id) + + "&task_id=" + encodeURIComponent(task_id) + + "&execution_date=" + encodeURIComponent(execution_date) + + "&metadata=null" + + "&format=file" Review comment: nit: semicolon in the end? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services