feng-tao commented on a change in pull request #4309: [AIRFLOW-3504]
Extend/refine the functionality of "/health" endpoint
URL: https://github.com/apache/incubator-airflow/pull/4309#discussion_r245173641
##########
File path: airflow/www_rbac/views.py
##########
@@ -147,6 +147,33 @@ def render(self, template, **context):
class Airflow(AirflowBaseView):
+ @expose('/health')
+ @provide_session
+ def health(self, session=None):
+ from sqlalchemy import func
Review comment:
why do local import instead of global import for the function? Do we have
namespace conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
