drewsonne commented on a change in pull request #4412: [AIRFLOW-3605] Load plugins from entry_points URL: https://github.com/apache/airflow/pull/4412#discussion_r246912582
########## File path: tests/plugins/test_plugins_manager_www.py ########## @@ -83,3 +85,66 @@ def test_menu_links(self): [menu_link] = [ml for ml in category.get_children() if isinstance(ml, MenuLink)] self.assertEqual('Test Menu Link', menu_link.name) + + +class MockPluginA(AirflowPlugin): + name = 'plugin-a' + + +class MockPluginB(AirflowPlugin): + name = 'plugin-b' + + +class MockPluginC(AirflowPlugin): + name = 'plugin-c' + + +class PluginsTestEntrypointLoad(unittest.TestCase): Review comment: I'm not sure, as I haven't touched on the UI parts of the code base yet. This code is not really anything to do with the UI as far as I'm aware. Or at least, it's not specific to one UI or the other. When I pulled the above PR changes in, this is where my code was move to, so the old test/plugin_manager.py file was renamed to this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services