potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile
URL: https://github.com/apache/airflow/pull/4483#issuecomment-454592984
 
 
   @ashb. Right - not Popen. The Popen difference was 2.7 vs. 3.x of course, 
but there were others we hit.
   
   One difference I documented 3.5 vs. 3.6 as bug (one that gave me most 
headeaches). You will understand when you look at it why it was a headache and 
why I needed to test it. There is very, very subtle difference of urlparse 
behaviour (hostname is not lowercased for some url types) in python 3.6 vs. 3.5 
(and s: https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-3615. I 
tested in 3.6 and it did not work in 3.5.
   
   The other one which we solved before it hit the repo was the dict insertion 
ordering (which works in 3.6 as implementation detail but not in 3.5). In 3.7 
it became language feature. There was comparision of keys in Bigtable column 
families vs. spec and initial implementation was implicitly relying on dict 
ordering (and did not use OrderedDict initially).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to